Fix(npub): Do not parse npubs in links

Author: brymut

lib/rehype-sn.js

@@ -73,17 +73,30 @@ export default function rehypeSN (options = {}) {
           }
         }
 
-        // only show a link as an embed if it doesn't have text siblings
-        if (node.tagName === 'a' &&
-                  !parent.children.some(s => s.type === 'text' && s.value.trim()) &&
-                  toString(node) === node.properties.href) {
-          const embed = parseEmbedUrl(node.properties.href)
-          if (embed) {
+        if (node.tagName === 'a') {
+          const href = node.properties.href
+          const textOnly = toString(node) === href
+          const hasTextSibling = parent.children.some(
+            s => s.type === 'text' && s.value.trim()
+          )
+          let embed
+          try {
+            embed = parseEmbedUrl(href)
+          } catch { /* invalid URL */ }
+
+          if (embed?.provider === 'nostr' && new URL(href).hostname === 'njump.me') {
+            node.tagName = 'embed'
+            node.properties = { ...embed, src: href }
+            return
+          }
+          if (embed && embed.provider !== 'nostr' && textOnly && !hasTextSibling) {
             node.tagName = 'embed'
-            node.properties = { ...embed, src: node.properties.href }
-          } else {
-            node.tagName = 'autolink'
+            node.properties = { ...embed, src: href }
+            return
           }
+
+          node.tagName = 'autolink'
+          return
         }
 
         // if the link text is a URL, just show the URL
@@ -136,8 +149,7 @@ export default function rehypeSN (options = {}) {
           }
         }
 
-        // Handle Nostr IDs
-        if (node.type === 'text') {
+        if (node.type === 'text' && !['a', 'autolink'].includes(parent?.tagName)) {
           const newChildren = []
           let lastIndex = 0
           let match
@@ -146,9 +158,7 @@ export default function rehypeSN (options = {}) {
             if (lastIndex < match.index) {
               newChildren.push({ type: 'text', value: node.value.slice(lastIndex, match.index) })
             }
-
             newChildren.push(replaceNostrId(match[0], match[0]))
-
             lastIndex = nostrIdRegex.lastIndex
           }