cleanup: remove unused nested comment counting, simpler topLevel/nested logic

Author: Soxasora

components/show-new-comments.js

@@ -19,19 +19,6 @@ function dedupeNewComments (newComments, comments) {
   return newComments.filter(id => !existingIds.has(id))
 }
 
-// recursively collects all new comments from an item and its children
-// by respecting the depth limit, we avoid collecting new comments to inject in places
-// that are too deep in the tree
-function collectAllNewComments (item, currentDepth = 1) {
-  const allNewComments = [...(item.newComments || [])]
-  if (item.comments?.comments && currentDepth < (COMMENT_DEPTH_LIMIT - 1)) {
-    for (const comment of item.comments.comments) {
-      allNewComments.push(...collectAllNewComments(comment, currentDepth + 1))
-    }
-  }
-  return allNewComments
-}
-
 // prepares and creates a new comments fragment for injection into the cache
 // returns a function that can be used to update an item's comments field
 function prepareComments (client, newComments) {
@@ -114,26 +101,14 @@ export const ShowNewComments = ({ topLevel, sort, comments, itemId, item, setHas
   // if item is provided, we're showing all new comments for a thread,
   // otherwise we're showing new comments for a comment
   const isThread = !topLevel && item?.path.split('.').length === 2
-  const allNewComments = useMemo(() => {
-    if (item) {
-      // TODO: well are we only collecting all new comments just for a fancy UI?
-      // TODO2: also, we're not deduping new comments here, so we're showing duplicates
-      return collectAllNewComments(item, depth)
-    }
-    return dedupeNewComments(newComments, comments)
-  }, [isThread, item, newComments, comments, depth])
+  const allNewComments = useMemo(() => dedupeNewComments(newComments, comments), [newComments, comments])
 
   const showNewComments = useCallback(() => {
-    if (isThread) {
-      showAllNewCommentsRecursively(client, item, depth)
+    if (topLevel) {
+      const payload = prepareComments(client, allNewComments)
+      itemUpdateQuery(client, itemId, sort, payload)
     } else {
-      if (topLevel) {
-        // fetch the latest version of the comments from the cache by their ids
-        const payload = prepareComments(client, allNewComments)
-        itemUpdateQuery(client, itemId, sort, payload)
-      } else {
-        showAllNewCommentsRecursively(client, item, depth)
-      }
+      showAllNewCommentsRecursively(client, item, depth)
     }
     setHasNewComments(false)
   }, [client, itemId, allNewComments, topLevel, sort, item])