favicon-new-comment, fix favicon showing also when there aren't new comments

Soxasora · Soxasora · commit 535afb803995 · 2025-07-12T13:19:25.000+02:00
diff --git a/components/comments.js b/components/comments.js
@@ -70,20 +70,19 @@ export default function Comments ({
   parentId, pinned, bio, parentCreatedAt,
   commentSats, comments, commentsCursor, fetchMoreComments, ncomments, newComments, lastCommentAt, ...props
 }) {
-  const [hasNewComments, setHasNewComments] = useState(false)
   const router = useRouter()
+  const [hasNewComments, setHasNewComments] = useState(false)
   // fetch new comments that arrived after the lastCommentAt, and update the item.newComments field in cache
   useLiveComments(parentId, lastCommentAt || parentCreatedAt, router.query.sort, setHasNewComments)
-  console.log('hasNewComments', hasNewComments)
-  console.log('sort', router.query.sort)
+  // xxx
   const hasNewNotes = useHasNewNotes()
 
   const pins = useMemo(() => comments?.filter(({ position }) => !!position).sort((a, b) => a.position - b.position), [comments])
 
   return (
     <>
       <Head>
-        <link rel='shortcut icon' href={hasNewComments ? '/favicon.png' : hasNewNotes ? '/favicon-notify.png' : '/favicon.png'} />
+        <link rel='shortcut icon' href={hasNewComments ? '/favicon-new-comment.png' : hasNewNotes ? '/favicon-notify.png' : '/favicon.png'} />
       </Head>
       {comments?.length > 0
         ? <CommentsHeader
diff --git a/components/use-live-comments.js b/components/use-live-comments.js
@@ -23,7 +23,7 @@ export default function useLiveComments (rootId, after, sort, setHasNewComments)
       })
 
   useEffect(() => {
-    if (!data?.newComments) return
+    if (!data?.newComments?.comments?.length) return
 
     // sometimes new comments can arrive as orphans because their parent might not be in the cache yet
     // queue them up, retry until the parent shows up.
diff --git a/public/favicon-new-comment.png b/public/favicon-new-comment.png
