Skip to content

Commit 3d03a26

Browse files
Apply suggestions from code review
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
1 parent 4034b26 commit 3d03a26

File tree

2 files changed

+2
-4
lines changed
  • docs/modules/trino/pages/usage-guide/catalogs
  • rust/operator-binary/src/crd/catalog

2 files changed

+2
-4
lines changed

docs/modules/trino/pages/usage-guide/catalogs/index.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Each connector supports a different set of attributes.
6262
You can use `.spec.configOverrides` to set arbitrary additional properties, which will be added to the catalog.
6363

6464
There is also `.spec.experimentalConfigRemovals` to remove any properties the operator might set, but are not used by Trino.
65-
This causes Trino to log an error message such as `Error: Configuration property 'hive.s3.aws-access-key' was not used` and refuse startup.
65+
This causes Trino to refuse to startup with an error message such as `Error: Configuration property 'hive.s3.aws-access-key' was not used`.
6666
By removing the unneeded properties you can get Trino to start again.
6767

6868
This example illustrates how to use config overrides and config removals

rust/operator-binary/src/crd/catalog/mod.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,7 @@ pub mod versioned {
5959
/// This is helpful, because Trino fails to start in case you have any unused config
6060
/// properties. The removals are executed after the `configOverrides`.
6161
///
62-
/// This field is experimental, as ideally some general solution for the removal of
63-
/// properties is found and added to configOverrides. This mechanism would replace this
64-
/// field.
62+
/// This field is experimental, and might be replaced by a more generic mechanism to edit config properties
6563
#[serde(default, rename = "experimentalConfigRemovals")]
6664
pub config_removals: Vec<String>,
6765
}

0 commit comments

Comments
 (0)