Skip to content

Commit fd3c029

Browse files
authored
Improve Release PR description (#34)
1 parent 4bd25c1 commit fd3c029

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

release/release.sh

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ ensure_release_branch() {
2727
}
2828

2929
maybe_create_github_pr() {
30-
local MESSAGE=${1}
30+
local MESSAGE=$@
3131
GH_COMMAND=$(which gh)
3232
if [ "$GH_COMMAND" != "" ]; then
33-
gh pr create --base $BASE_BRANCH --head $RELEASE_BRANCH --title $MESSAGE --body $MESSAGE
33+
gh pr create --base $BASE_BRANCH --head $RELEASE_BRANCH --title "$MESSAGE" --body "$MESSAGE"
3434
fi
3535
}
3636

@@ -64,7 +64,8 @@ main() {
6464
MESSAGE="release $RELEASE_VERSION"
6565
git commit -am "release $RELEASE_VERSION"
6666
git tag -a $RELEASE_VERSION -m "release $RELEASE_VERSION"
67-
git tag -a docs/$DOCS_VERSION -m "docs $DOCS_VERSION"
67+
# We don't want to tag the docs in all the cases, as some manual steps might be needed (e.g. updating getting started guides)
68+
# git tag -a docs/$DOCS_VERSION -m "docs $DOCS_VERSION"
6869

6970
else
7071
#

0 commit comments

Comments
 (0)