Skip to content

Commit b29595e

Browse files
authored
Added check to bulk pr scripts to bail if no parameter is given when running the scripts (#51)
* Added check to bulk pr scripts to bail if no parameter is given when running the script. All of these scripts require the branch name the prs are based on to work and will not do any work otherwise. * Added 'set -euo pipefail' to all shell scripts.
1 parent 67df4f0 commit b29595e

File tree

6 files changed

+21
-9
lines changed

6 files changed

+21
-9
lines changed

bulk-pr/pr_approve

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
#!/usr/bin/env bash
2+
set -euo pipefail
3+
PR_BRANCH_NAME=${1:?Must provide name of PR branch to operate on.}
24
source repos
35
for product in "${products[@]}"; do
4-
STATE=$(gh pr view $1 -R stackabletech/${product}-operator --jq '.state' --json state)
6+
STATE=$(gh pr view ${PR_BRANCH_NAME} -R stackabletech/${product}-operator --jq '.state' --json state)
57
if [[ $STATE -eq "OPEN" ]]; then
68
echo "Approving ${product}"
7-
gh pr review $1 --approve -R stackabletech/${product}-operator
8-
gh pr merge $1 -R stackabletech/${product}-operator
9+
gh pr review ${PR_BRANCH_NAME} --approve -R stackabletech/${product}-operator
10+
gh pr merge ${PR_BRANCH_NAME} -R stackabletech/${product}-operator
911
else
1012
echo "Skipping ${product}, PR already closed"
1113
fi

bulk-pr/pr_checks

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#!/usr/bin/env bash
2+
set -euo pipefail
3+
PR_BRANCH_NAME=${1:?Must provide name of PR branch to operate on.}
24
source repos
35
for product in "${products[@]}"; do
4-
gh pr checks $1 -R stackabletech/${product}-operator
6+
gh pr checks ${PR_BRANCH_NAME} -R stackabletech/${product}-operator
57
done
68

bulk-pr/pr_close

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
#!/usr/bin/env bash
2+
set -euo pipefail
3+
PR_BRANCH_NAME=${1:?Must provide name of PR branch to operate on.}
24
source repos
35
for product in "${products[@]}"; do
4-
STATE=$(gh pr view $1 -R stackabletech/${product}-operator --jq '.state' --json state)
6+
STATE=$(gh pr view ${PR_BRANCH_NAME} -R stackabletech/${product}-operator --jq '.state' --json state)
57
if [[ $STATE -eq "OPEN" ]]; then
6-
gh pr close $1 -R stackabletech/${product}-operator
8+
gh pr close ${PR_BRANCH_NAME} -R stackabletech/${product}-operator
79
else
810
echo "Skipping ${product}, PR already closed"
911
fi

bulk-pr/pr_diffs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#!/usr/bin/env bash
2+
set -euo pipefail
3+
PR_BRANCH_NAME=${1:?Must provide name of PR branch to operate on.}
24
source repos
35
for product in "${products[@]}"; do
4-
gh pr diff $1 -R stackabletech/${product}-operator
6+
gh pr diff ${PR_BRANCH_NAME} -R stackabletech/${product}-operator
57
done
68

bulk-pr/pr_list

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#!/usr/bin/env bash
2+
set -euo pipefail
3+
PR_BRANCH_NAME=${1:?Must provide name of PR branch to operate on.}
24
source repos
35
# Disable gh paging for results.
46
PAGER=

bulk-pr/pr_status

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
#!/usr/bin/env bash
2+
set -euo pipefail
3+
PR_BRANCH_NAME=${1:?Must provide name of PR branch to operate on.}
24
source repos
35
for product in "${products[@]}"; do
4-
STATE=$(gh pr view $1 -R stackabletech/${product}-operator --jq '.state' --json state)
5-
gh pr checks $1 -R stackabletech/${product}-operator &> /dev/null
6+
STATE=$(gh pr view ${PR_BRANCH_NAME} -R stackabletech/${product}-operator --jq '.state' --json state)
7+
gh pr checks ${PR_BRANCH_NAME} -R stackabletech/${product}-operator &> /dev/null
68
status=$?
79
echo "${product}(${STATE}): ${status}"
810
done

0 commit comments

Comments
 (0)