Skip to content

Commit 3437844

Browse files
committed
Update ESLint workflow step
1 parent dababc4 commit 3437844

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

.github/workflows/pr_cockpit-web.yml

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,18 @@ jobs:
2121
- run: yarn install --frozen-lockfile
2222
- run: yarn --cwd web run build
2323

24+
eslint:
25+
name: Run web linting via ESLint
26+
runs-on: ubuntu-latest
27+
steps:
28+
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
29+
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
30+
with:
31+
node-version: 18
32+
cache: yarn
33+
- run: yarn install --frozen-lockfile
34+
- run: yarn --cwd web run lint
35+
2436
prettier:
2537
name: Validate web formatting
2638
runs-on: ubuntu-latest
@@ -37,4 +49,4 @@ jobs:
3749
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
3850
with:
3951
script: |
40-
core.setFailed('web/ contains unformatted code, run `pnpm prettier . --write` and re-commit!')
52+
core.setFailed('web/ contains unformatted code, run `yarn --cwd web run format --write` and re-commit!')

.github/workflows/pr_reviewdog.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,6 @@ jobs:
1818
with:
1919
github_token: ${{ secrets.GITHUB_TOKEN }}
2020

21-
eslint:
22-
runs-on: ubuntu-latest
23-
steps:
24-
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0
25-
- uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0
26-
with:
27-
version: 7.26.1
28-
run_install: true
29-
- uses: reviewdog/action-eslint@423672b7acbb75ee34d3e37aff30949ddc8350e3 # v1.24.0
30-
with:
31-
workdir: web
32-
github_token: ${{ secrets.GITHUB_TOKEN }}
33-
3421
flake8:
3522
runs-on: ubuntu-latest
3623
steps:

0 commit comments

Comments
 (0)