Skip to content

Commit ea12f24

Browse files
razvansbernauer
andauthored
Apply suggestions from code review
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
1 parent ecd63cd commit ea12f24

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

crates/stackable-operator/src/utils/kubelet.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@ use crate::commons::networking::DomainName;
1414
pub enum Error {
1515
#[snafu(display("failed to list nodes"))]
1616
ListNodes { source: kube::Error },
17-
#[snafu(display("failed to build proxy/configz request"))]
17+
18+
#[snafu(display("failed to build \"/proxy/configz\" request"))]
1819
ConfigzRequest { source: http::Error },
1920

20-
#[snafu(display("failed to fetch kubelet config from node {node}"))]
21+
#[snafu(display("failed to fetch kubelet config from node {node:?}"))]
2122
FetchNodeKubeletConfig { source: kube::Error, node: String },
2223

2324
#[snafu(display("failed to fetch `kubeletconfig` JSON key from configz response"))]
@@ -51,10 +52,9 @@ impl KubeletConfig {
5152
.await
5253
.context(ListNodesSnafu)?;
5354
let node = nodes.iter().next().context(EmptyKubernetesNodesListSnafu)?;
55+
let node_name = node.name_any();
5456

55-
let name = node.name_any();
56-
57-
let url = format!("/api/v1/nodes/{}/proxy/configz", name);
57+
let url = format!("/api/v1/nodes/{name_name}/proxy/configz");
5858
let req = http::Request::get(url)
5959
.body(Default::default())
6060
.context(ConfigzRequestSnafu)?;

0 commit comments

Comments
 (0)