Skip to content

Commit 4a07fd3

Browse files
committed
review feedback
1 parent 2e71f67 commit 4a07fd3

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

crates/stackable-operator/src/utils/kubelet.rs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ pub enum Error {
1515
#[snafu(display("failed to list nodes"))]
1616
ListNodes { source: kube::Error },
1717

18-
#[snafu(display("failed to build \"/api/v1/nodes/{node_name}/proxy/configz\" request"))]
19-
ConfigzRequest {
18+
#[snafu(display("failed to build request for url path \"{url_path}\""))]
19+
BuildConfigzRequest {
2020
source: http::Error,
21-
node_name: String,
21+
url_path: String,
2222
},
2323

2424
#[snafu(display("failed to fetch kubelet config from node {node:?}"))]
@@ -59,13 +59,10 @@ impl KubeletConfig {
5959
let node = nodes.iter().next().context(EmptyKubernetesNodesListSnafu)?;
6060
let node_name = node.name_any();
6161

62-
let url = format!("/api/v1/nodes/{node_name}/proxy/configz");
63-
let req =
64-
http::Request::get(url)
65-
.body(Default::default())
66-
.context(ConfigzRequestSnafu {
67-
node_name: node_name.clone(),
68-
})?;
62+
let url_path = format!("/api/v1/nodes/{node_name}/proxy/configz");
63+
let req = http::Request::get(url_path.clone())
64+
.body(Default::default())
65+
.context(BuildConfigzRequestSnafu { url_path })?;
6966

7067
let resp = client
7168
.request::<ProxyConfigResponse>(req)

0 commit comments

Comments
 (0)