Skip to content

Commit 46d77e1

Browse files
authored
fix: Fix the CRD description of ClientAuthenticationDetails (#846)
* fix: Fix the CRD description of ClientAuthenticationDetails * changelog * fix * fix
1 parent c77a542 commit 46d77e1

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

crates/stackable-operator/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Fixed
8+
9+
- Fix the CRD description of `ClientAuthenticationDetails` to not contain internal Rust doc, but a public CRD description ([#846]).
10+
11+
[#846]: https://github.com/stackabletech/operator-rs/pull/846
12+
713
## [0.74.0] - 2024-08-22
814

915
### Added

crates/stackable-operator/src/commons/authentication/mod.rs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -125,15 +125,17 @@ impl AuthenticationClass {
125125
#[serde(rename_all = "camelCase")]
126126
#[schemars(description = "")]
127127
pub struct ClientAuthenticationDetails<O = ()> {
128-
/// A name/key which references an authentication class. To get the concrete
129-
/// [`AuthenticationClass`], we must resolve it. This resolution can be
130-
/// achieved by using [`ClientAuthenticationDetails::resolve_class`].
128+
/// Name of the [AuthenticationClass](https://docs.stackable.tech/home/nightly/concepts/authentication) used to
129+
/// authenticate users.
130+
//
131+
// To get the concrete [`AuthenticationClass`], we must resolve it. This resolution can be achieved by using
132+
// [`ClientAuthenticationDetails::resolve_class`].
131133
#[serde(rename = "authenticationClass")]
132134
authentication_class_ref: String,
133135

134-
/// This field contains authentication provider specific configuration.
135-
///
136-
/// Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
136+
/// This field contains OIDC-specific configuration. It is only required in case OIDC is used.
137+
//
138+
// Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
137139
// TODO: Ideally we want this to be an enum once other `ClientAuthenticationOptions` are added, so
138140
// that user can not configure multiple options at the same time (yes we are aware that this makes a
139141
// changing the type of an AuthenticationClass harder).

crates/stackable-operator/src/commons/authentication/oidc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,8 @@ pub struct ClientAuthenticationOptions<T = ()> {
232232
#[serde(default)]
233233
pub extra_scopes: Vec<String>,
234234

235-
/// If desired, operators can add custom fields that are only needed for this specific product.
236-
/// They need to create a struct holding them and pass that as `T`.
235+
// If desired, operators can add custom fields that are only needed for this specific product.
236+
// They need to create a struct holding them and pass that as `T`.
237237
#[serde(flatten)]
238238
pub product_specific_fields: T,
239239
}

0 commit comments

Comments
 (0)