File tree Expand file tree Collapse file tree 3 files changed +16
-8
lines changed
crates/stackable-operator
src/commons/authentication Expand file tree Collapse file tree 3 files changed +16
-8
lines changed Original file line number Diff line number Diff line change @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
4
4
5
5
## [ Unreleased]
6
6
7
+ ### Fixed
8
+
9
+ - Fix the CRD description of ` ClientAuthenticationDetails ` to not contain internal Rust doc, but a public CRD description ([ #846 ] ).
10
+
11
+ [ #846 ] : https://github.com/stackabletech/operator-rs/pull/846
12
+
7
13
## [ 0.74.0] - 2024-08-22
8
14
9
15
### Added
Original file line number Diff line number Diff line change @@ -125,15 +125,17 @@ impl AuthenticationClass {
125
125
#[ serde( rename_all = "camelCase" ) ]
126
126
#[ schemars( description = "" ) ]
127
127
pub struct ClientAuthenticationDetails < O = ( ) > {
128
- /// A name/key which references an authentication class. To get the concrete
129
- /// [`AuthenticationClass`], we must resolve it. This resolution can be
130
- /// achieved by using [`ClientAuthenticationDetails::resolve_class`].
128
+ /// Name of the [AuthenticationClass](https://docs.stackable.tech/home/nightly/concepts/authentication) used to
129
+ /// authenticate users.
130
+ //
131
+ // To get the concrete [`AuthenticationClass`], we must resolve it. This resolution can be achieved by using
132
+ // [`ClientAuthenticationDetails::resolve_class`].
131
133
#[ serde( rename = "authenticationClass" ) ]
132
134
authentication_class_ref : String ,
133
135
134
- /// This field contains authentication provider specific configuration.
135
- ///
136
- /// Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
136
+ /// This field contains OIDC- specific configuration. It is only required in case OIDC is used .
137
+ //
138
+ // Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
137
139
// TODO: Ideally we want this to be an enum once other `ClientAuthenticationOptions` are added, so
138
140
// that user can not configure multiple options at the same time (yes we are aware that this makes a
139
141
// changing the type of an AuthenticationClass harder).
Original file line number Diff line number Diff line change @@ -232,8 +232,8 @@ pub struct ClientAuthenticationOptions<T = ()> {
232
232
#[ serde( default ) ]
233
233
pub extra_scopes : Vec < String > ,
234
234
235
- /// If desired, operators can add custom fields that are only needed for this specific product.
236
- /// They need to create a struct holding them and pass that as `T`.
235
+ // If desired, operators can add custom fields that are only needed for this specific product.
236
+ // They need to create a struct holding them and pass that as `T`.
237
237
#[ serde( flatten) ]
238
238
pub product_specific_fields : T ,
239
239
}
You can’t perform that action at this time.
0 commit comments