Skip to content

Commit af1970e

Browse files
razvansbernauer
andauthored
remove init container from daemonset (#174)
* chore: remove init container * update changelog * Update CHANGELOG.md Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de> --------- Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
1 parent 71aba4b commit af1970e

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Removed
8+
9+
- Init container deployed by the Helm chart as part of the daemonset. It was added a an automatic migration between SDP versions and is not needed anymore ([#174]).
10+
11+
[#174]: https://github.com/stackabletech/listener-operator/pull/174
12+
713
## [24.3.0] - 2024-03-20
814

915
### Added

deploy/helm/listener-operator/templates/node-daemonset.yaml

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -64,33 +64,6 @@ spec:
6464
mountPath: /registration
6565
- name: csi
6666
mountPath: /csi
67-
initContainers:
68-
# https://github.com/stackabletech/listener-operator/issues/76
69-
# In https://github.com/stackabletech/listener-operator/pull/45 we introduced a breaking change by shortening the CSI registration path
70-
# This resulted in the following error "node_register.go:43] file exists in socketPath /registration/listeners.stackable.tech-reg.sock but it's not a socket.: &{name:listeners.stackable.tech-reg.sock size:4096 mode:2147484141 modTime:{wall:984732078ext:63815759330 loc:0xf864a0} sys:{Dev:64769 Ino:43688551 Nlink:2 Mode:16877 Uid:0 Gid:0 X__pad0:0 Rdev:0 Size:4096 Blksize:4096 Blocks:8 Atim:{Sec:1680162505 Nsec:36073186} Mtim:{Sec:1680162530 Nsec:984732078} Ctim:{Sec:1680162530 Nsec:984732078} X__unused:[0 0 0]}}"
71-
# This init container removes the "old" directory, so that a unix socket with the same path can be created instead
72-
# TODO: Should be removed in a release after 23.4
73-
- name: migrate-longer-csi-registration-path
74-
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
75-
imagePullPolicy: {{ .Values.image.pullPolicy }}
76-
resources:
77-
{{ .Values.node.driver.resources | toYaml | nindent 12 }}
78-
command:
79-
- /bin/bash
80-
- -euo
81-
- pipefail
82-
- -x
83-
- -c
84-
- |
85-
ls -la /registration
86-
echo "Removing old (long) CSI registration path"
87-
if [ -d "/registration/listeners.stackable.tech-reg.sock" ]; then rmdir /registration/listeners.stackable.tech-reg.sock; fi
88-
ls -la /registration
89-
volumeMounts:
90-
- name: registration-sock
91-
mountPath: /registration
92-
securityContext:
93-
runAsUser: 0
9467
volumes:
9568
- name: registration-sock
9669
hostPath:

0 commit comments

Comments
 (0)