Skip to content

Commit c219fd6

Browse files
Merge pull request #794 from stackabletech/update-release-branch
Update release branch
2 parents c32d79e + bad8c0a commit c219fd6

File tree

9 files changed

+33
-44
lines changed

9 files changed

+33
-44
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Fixed
8+
9+
- BREAKING: Use distinct ServiceAccounts for the Stacklets, so that multiple Stacklets can be
10+
deployed in one namespace. Existing Stacklets will use the newly created ServiceAccounts after
11+
restart ([#793]).
12+
13+
[#793]: https://github.com/stackabletech/kafka-operator/pull/793
14+
715
## [24.11.0] - 2024-11-18
816

917
### Added

Cargo.lock

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.nix

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ serde = { version = "1.0", features = ["derive"] }
2222
serde_json = "1.0"
2323
serde_yaml = "0.9"
2424
snafu = "0.8"
25-
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.80.0" }
25+
stackable-operator = { git = "https://github.com/stackabletech/operator-rs.git", tag = "stackable-operator-0.82.0" }
2626
strum = { version = "0.26", features = ["derive"] }
2727
tokio = { version = "1.40", features = ["full"] }
2828
tracing = "0.1"

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ SHELL=/usr/bin/env bash -euo pipefail
2929
render-readme:
3030
scripts/render_readme.sh
3131

32+
render-docs:
33+
scripts/docs_templating.sh
34+
3235
## Docker related targets
3336
docker-build:
3437
docker build --force-rm --build-arg VERSION=${VERSION} -t "${DOCKER_REPO}/${ORGANIZATION}/${OPERATOR_NAME}:${VERSION}-${ARCH}" -f docker/Dockerfile .

crate-hashes.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/modules/kafka/examples/getting_started/getting_started.sh

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,7 @@
22
set -euo pipefail
33

44
# DO NOT EDIT THE SCRIPT
5-
# Instead, update the j2 template, and regenerate it for dev:
6-
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
7-
# helm:
8-
# repo_name: stackable-dev
9-
# repo_url: https://repo.stackable.tech/repository/helm-dev/
10-
# versions:
11-
# commons: 0.0.0-dev
12-
# kafka: 0.0.0-dev
13-
# listener: 0.0.0-dev
14-
# secret: 0.0.0-dev
15-
# zookeeper: 0.0.0-dev
16-
# EOF
5+
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.
176

187
# The getting started guide script
198
# It uses tagged regions which are included in the documentation

docs/modules/kafka/examples/getting_started/getting_started.sh.j2

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,7 @@
22
set -euo pipefail
33

44
# DO NOT EDIT THE SCRIPT
5-
# Instead, update the j2 template, and regenerate it for dev:
6-
# cat <<EOF | jinja2 --format yaml getting_started.sh.j2 -o getting_started.sh
7-
# helm:
8-
# repo_name: stackable-dev
9-
# repo_url: https://repo.stackable.tech/repository/helm-dev/
10-
# versions:
11-
# commons: 0.0.0-dev
12-
# kafka: 0.0.0-dev
13-
# listener: 0.0.0-dev
14-
# secret: 0.0.0-dev
15-
# zookeeper: 0.0.0-dev
16-
# EOF
5+
# Instead, update the j2 template, and regenerate it for dev with `make render-docs`.
176

187
# The getting started guide script
198
# It uses tagged regions which are included in the documentation

rust/operator-binary/src/kafka_controller.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ use stackable_operator::{
4848
core::v1::{
4949
ConfigMap, ConfigMapKeySelector, ConfigMapVolumeSource, ContainerPort, EnvVar,
5050
EnvVarSource, ExecAction, ObjectFieldSelector, PodSpec, Probe, Service,
51-
ServiceSpec, Volume,
51+
ServiceAccount, ServiceSpec, Volume,
5252
},
5353
},
5454
apimachinery::pkg::apis::meta::v1::LabelSelector,
@@ -524,7 +524,7 @@ pub async fn reconcile_kafka(
524524
.context(BuildRbacResourcesSnafu)?;
525525

526526
let rbac_sa = cluster_resources
527-
.add(client, rbac_sa)
527+
.add(client, rbac_sa.clone())
528528
.await
529529
.context(ApplyServiceAccountSnafu)?;
530530
cluster_resources
@@ -561,7 +561,7 @@ pub async fn reconcile_kafka(
561561
opa_connect.as_deref(),
562562
&kafka_security,
563563
&merged_config,
564-
&rbac_sa.name_any(),
564+
&rbac_sa,
565565
&client.kubernetes_cluster_info,
566566
)?;
567567
let rg_bootstrap_listener = build_broker_rolegroup_bootstrap_listener(
@@ -824,7 +824,7 @@ fn build_broker_rolegroup_statefulset(
824824
opa_connect_string: Option<&str>,
825825
kafka_security: &KafkaTlsSecurity,
826826
merged_config: &KafkaConfig,
827-
sa_name: &str,
827+
service_account: &ServiceAccount,
828828
cluster_info: &KubernetesClusterInfo,
829829
) -> Result<StatefulSet> {
830830
let role = kafka.role(kafka_role).context(InternalOperatorSnafu)?;
@@ -1096,7 +1096,7 @@ fn build_broker_rolegroup_statefulset(
10961096
)),
10971097
)
10981098
.context(AddVolumeSnafu)?
1099-
.service_account_name(sa_name)
1099+
.service_account_name(service_account.name_any())
11001100
.security_context(
11011101
PodSecurityContextBuilder::new()
11021102
.run_as_user(KAFKA_UID)

0 commit comments

Comments
 (0)