|
| 1 | +use crate::crd::{ |
| 2 | + v1alpha1::HiveCluster, MetaStoreConfig, MetaStoreConfigFragment, JVM_SECURITY_PROPERTIES_FILE, |
| 3 | + METRICS_PORT, STACKABLE_CONFIG_DIR, STACKABLE_TRUST_STORE, STACKABLE_TRUST_STORE_PASSWORD, |
| 4 | +}; |
| 5 | +use snafu::{OptionExt, ResultExt, Snafu}; |
| 6 | +use stackable_operator::{ |
| 7 | + memory::{BinaryMultiple, MemoryQuantity}, |
| 8 | + role_utils::{self, GenericRoleConfig, JavaCommonConfig, JvmArgumentOverrides, Role}, |
| 9 | +}; |
| 10 | + |
| 11 | +const JAVA_HEAP_FACTOR: f32 = 0.8; |
| 12 | + |
| 13 | +#[derive(Snafu, Debug)] |
| 14 | +pub enum Error { |
| 15 | + #[snafu(display("invalid memory resource configuration - missing default or value in crd?"))] |
| 16 | + MissingMemoryResourceConfig, |
| 17 | + |
| 18 | + #[snafu(display("invalid memory config"))] |
| 19 | + InvalidMemoryConfig { |
| 20 | + source: stackable_operator::memory::Error, |
| 21 | + }, |
| 22 | + |
| 23 | + #[snafu(display("failed to merge jvm argument overrides"))] |
| 24 | + MergeJvmArgumentOverrides { source: role_utils::Error }, |
| 25 | +} |
| 26 | + |
| 27 | +/// All JVM arguments. |
| 28 | +fn construct_jvm_args( |
| 29 | + hive: &HiveCluster, |
| 30 | + merged_config: &MetaStoreConfig, |
| 31 | + role: &Role<MetaStoreConfigFragment, GenericRoleConfig, JavaCommonConfig>, |
| 32 | + role_group: &str, |
| 33 | +) -> Result<Vec<String>, Error> { |
| 34 | + let heap_size = MemoryQuantity::try_from( |
| 35 | + merged_config |
| 36 | + .resources |
| 37 | + .memory |
| 38 | + .limit |
| 39 | + .as_ref() |
| 40 | + .context(MissingMemoryResourceConfigSnafu)?, |
| 41 | + ) |
| 42 | + .context(InvalidMemoryConfigSnafu)? |
| 43 | + .scale_to(BinaryMultiple::Mebi) |
| 44 | + * JAVA_HEAP_FACTOR; |
| 45 | + let java_heap = heap_size |
| 46 | + .format_for_java() |
| 47 | + .context(InvalidMemoryConfigSnafu)?; |
| 48 | + |
| 49 | + let mut jvm_args = vec![ |
| 50 | + // Heap settings |
| 51 | + format!("-Xmx{java_heap}"), |
| 52 | + format!("-Xms{java_heap}"), |
| 53 | + format!("-Djava.security.properties={STACKABLE_CONFIG_DIR}/{JVM_SECURITY_PROPERTIES_FILE}"), |
| 54 | + format!("-javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar={METRICS_PORT}:/stackable/jmx/jmx_hive_config.yaml"), |
| 55 | + format!("-Djavax.net.ssl.trustStore={STACKABLE_TRUST_STORE}"), |
| 56 | + format!("-Djavax.net.ssl.trustStorePassword={STACKABLE_TRUST_STORE_PASSWORD}"), |
| 57 | + format!("-Djavax.net.ssl.trustStoreType=pkcs12"), |
| 58 | + ]; |
| 59 | + |
| 60 | + if hive.has_kerberos_enabled() { |
| 61 | + jvm_args.push("-Djava.security.krb5.conf=/stackable/kerberos/krb5.conf".to_owned()); |
| 62 | + } |
| 63 | + |
| 64 | + let operator_generated = JvmArgumentOverrides::new_with_only_additions(jvm_args); |
| 65 | + let merged = role |
| 66 | + .get_merged_jvm_argument_overrides(role_group, &operator_generated) |
| 67 | + .context(MergeJvmArgumentOverridesSnafu)?; |
| 68 | + Ok(merged |
| 69 | + .effective_jvm_config_after_merging() |
| 70 | + // Sorry for the clone, that's how operator-rs is currently modelled :P |
| 71 | + .clone()) |
| 72 | +} |
| 73 | + |
| 74 | +/// Arguments that go into `HADOOP_OPTS`, so *not* the heap settings (which you can get using |
| 75 | +/// [`construct_heap_jvm_args`]). |
| 76 | +pub fn construct_non_heap_jvm_args( |
| 77 | + hive: &HiveCluster, |
| 78 | + merged_config: &MetaStoreConfig, |
| 79 | + role: &Role<MetaStoreConfigFragment, GenericRoleConfig, JavaCommonConfig>, |
| 80 | + role_group: &str, |
| 81 | +) -> Result<String, Error> { |
| 82 | + let mut jvm_args = construct_jvm_args(hive, merged_config, role, role_group)?; |
| 83 | + jvm_args.retain(|arg| !is_heap_jvm_argument(arg)); |
| 84 | + |
| 85 | + Ok(jvm_args.join(" ")) |
| 86 | +} |
| 87 | + |
| 88 | +/// Arguments that go into `HADOOP_HEAPSIZE`. |
| 89 | +/// You can get the normal JVM arguments using [`construct_non_heap_jvm_args`]. |
| 90 | +pub fn construct_heap_jvm_args( |
| 91 | + hive: &HiveCluster, |
| 92 | + merged_config: &MetaStoreConfig, |
| 93 | + role: &Role<MetaStoreConfigFragment, GenericRoleConfig, JavaCommonConfig>, |
| 94 | + role_group: &str, |
| 95 | +) -> Result<String, Error> { |
| 96 | + let mut jvm_args = construct_jvm_args(hive, merged_config, role, role_group)?; |
| 97 | + jvm_args.retain(|arg| is_heap_jvm_argument(arg)); |
| 98 | + |
| 99 | + Ok(jvm_args.join(" ")) |
| 100 | +} |
| 101 | + |
| 102 | +fn is_heap_jvm_argument(jvm_argument: &str) -> bool { |
| 103 | + let lowercase = jvm_argument.to_lowercase(); |
| 104 | + |
| 105 | + lowercase.starts_with("-xms") || lowercase.starts_with("-xmx") |
| 106 | +} |
| 107 | + |
| 108 | +#[cfg(test)] |
| 109 | +mod tests { |
| 110 | + use crate::crd::HiveRole; |
| 111 | + |
| 112 | + use super::*; |
| 113 | + |
| 114 | + #[test] |
| 115 | + fn test_construct_jvm_arguments_defaults() { |
| 116 | + let input = r#" |
| 117 | + apiVersion: hive.stackable.tech/v1alpha1 |
| 118 | + kind: HiveCluster |
| 119 | + metadata: |
| 120 | + name: simple-hive |
| 121 | + spec: |
| 122 | + image: |
| 123 | + productVersion: 4.0.0 |
| 124 | + clusterConfig: |
| 125 | + database: |
| 126 | + connString: jdbc:derby:;databaseName=/tmp/hive;create=true |
| 127 | + dbType: derby |
| 128 | + credentialsSecret: mySecret |
| 129 | + metastore: |
| 130 | + roleGroups: |
| 131 | + default: |
| 132 | + replicas: 1 |
| 133 | + "#; |
| 134 | + let (hive, hive_role, role, merged_config) = construct_boilerplate(input); |
| 135 | + let non_heap_jvm_args = |
| 136 | + construct_non_heap_jvm_args(&hive, &hive_role, &role, &merged_config).unwrap(); |
| 137 | + let heap_jvm_args = |
| 138 | + construct_heap_jvm_args(&hive, &hive_role, &role, &merged_config).unwrap(); |
| 139 | + |
| 140 | + assert_eq!( |
| 141 | + non_heap_jvm_args, |
| 142 | + "-Djava.security.properties=/stackable/config/security.properties \ |
| 143 | + -javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar=9084:/stackable/jmx/jmx_hive_config.yaml \ |
| 144 | + -Djavax.net.ssl.trustStore=/stackable/truststore.p12 \ |
| 145 | + -Djavax.net.ssl.trustStorePassword=changeit \ |
| 146 | + -Djavax.net.ssl.trustStoreType=pkcs12" |
| 147 | + ); |
| 148 | + assert_eq!(heap_jvm_args, "-Xmx409m -Xms409m"); |
| 149 | + } |
| 150 | + |
| 151 | + #[test] |
| 152 | + fn test_construct_jvm_argument_overrides() { |
| 153 | + let input = r#" |
| 154 | + apiVersion: hive.stackable.tech/v1alpha1 |
| 155 | + kind: HiveCluster |
| 156 | + metadata: |
| 157 | + name: simple-hive |
| 158 | + spec: |
| 159 | + image: |
| 160 | + productVersion: 4.0.0 |
| 161 | + clusterConfig: |
| 162 | + database: |
| 163 | + connString: jdbc:derby:;databaseName=/tmp/hive;create=true |
| 164 | + dbType: derby |
| 165 | + credentialsSecret: mySecret |
| 166 | + metastore: |
| 167 | + config: |
| 168 | + resources: |
| 169 | + memory: |
| 170 | + limit: 42Gi |
| 171 | + jvmArgumentOverrides: |
| 172 | + add: |
| 173 | + - -Dhttps.proxyHost=proxy.my.corp |
| 174 | + - -Dhttps.proxyPort=8080 |
| 175 | + - -Djava.net.preferIPv4Stack=true |
| 176 | + roleGroups: |
| 177 | + default: |
| 178 | + replicas: 1 |
| 179 | + jvmArgumentOverrides: |
| 180 | + # We need more memory! |
| 181 | + removeRegex: |
| 182 | + - -Xmx.* |
| 183 | + - -Dhttps.proxyPort=.* |
| 184 | + add: |
| 185 | + - -Xmx40000m |
| 186 | + - -Dhttps.proxyPort=1234 |
| 187 | + "#; |
| 188 | + let (hive, merged_config, role, role_group) = construct_boilerplate(input); |
| 189 | + let non_heap_jvm_args = |
| 190 | + construct_non_heap_jvm_args(&hive, &merged_config, &role, &role_group).unwrap(); |
| 191 | + let heap_jvm_args = |
| 192 | + construct_heap_jvm_args(&hive, &merged_config, &role, &role_group).unwrap(); |
| 193 | + |
| 194 | + assert_eq!( |
| 195 | + non_heap_jvm_args, |
| 196 | + "-Djava.security.properties=/stackable/config/security.properties \ |
| 197 | + -javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar=9084:/stackable/jmx/jmx_hive_config.yaml \ |
| 198 | + -Djavax.net.ssl.trustStore=/stackable/truststore.p12 \ |
| 199 | + -Djavax.net.ssl.trustStorePassword=changeit \ |
| 200 | + -Djavax.net.ssl.trustStoreType=pkcs12 \ |
| 201 | + -Dhttps.proxyHost=proxy.my.corp \ |
| 202 | + -Djava.net.preferIPv4Stack=true \ |
| 203 | + -Dhttps.proxyPort=1234" |
| 204 | + ); |
| 205 | + assert_eq!(heap_jvm_args, "-Xms34406m -Xmx40000m"); |
| 206 | + } |
| 207 | + |
| 208 | + fn construct_boilerplate( |
| 209 | + hive_cluster: &str, |
| 210 | + ) -> ( |
| 211 | + HiveCluster, |
| 212 | + MetaStoreConfig, |
| 213 | + Role<MetaStoreConfigFragment, GenericRoleConfig, JavaCommonConfig>, |
| 214 | + String, |
| 215 | + ) { |
| 216 | + let hive: HiveCluster = serde_yaml::from_str(hive_cluster).expect("illegal test input"); |
| 217 | + |
| 218 | + let hive_role = HiveRole::MetaStore; |
| 219 | + let rolegroup_ref = hive.metastore_rolegroup_ref("default"); |
| 220 | + let merged_config = hive.merged_config(&hive_role, &rolegroup_ref).unwrap(); |
| 221 | + let role = hive.spec.metastore.clone().unwrap(); |
| 222 | + |
| 223 | + (hive, merged_config, role, "default".to_owned()) |
| 224 | + } |
| 225 | +} |
0 commit comments