Skip to content

Commit a4428a9

Browse files
test(smoke): Test boolean metrics (#690)
* test(smoke): Test boolean metrics * Format Python file
1 parent e903159 commit a4428a9

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

tests/templates/kuttl/smoke/test_metrics.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ def check_metrics(
1717
assert response.ok, "Requesting metrics failed"
1818

1919
for metric in expected_metrics:
20-
assert (
21-
re.search(f"^{metric}", response.text, re.MULTILINE) is not None
22-
), f"Metric '{metric}' not found for {role}"
20+
assert re.search(f"^{metric}", response.text, re.MULTILINE) is not None, (
21+
f"Metric '{metric}' not found for {role}"
22+
)
2323

2424

2525
def check_namenode_metrics(
@@ -35,6 +35,8 @@ def check_namenode_metrics(
3535
'hadoop_namenode_files_total{kind="FSNamesystem",role="NameNode",service="HDFS"}',
3636
# Metric suffixed with "_created"
3737
'hadoop_namenode_files_created_{kind="NameNodeActivity",role="NameNode",service="HDFS"}',
38+
# Boolean metric
39+
'hadoop_namenode_security_enabled{kind="NameNodeStatus",role="NameNode",service="HDFS"}',
3840
# Non-special metric
3941
'hadoop_namenode_files_deleted{kind="NameNodeActivity",role="NameNode",service="HDFS"}',
4042
]
@@ -68,6 +70,8 @@ def check_datanode_metrics(
6870
'hadoop_datanode_blocks_read{host="hdfs-datanode-default-0\\.hdfs-datanode-default\\..+\\.svc\\.cluster\\.local",kind="DataNodeActivity",port="9866",role="DataNode",service="HDFS"}',
6971
# Counter suffixed with "_total"
7072
'hadoop_datanode_estimated_capacity_lost_total{kind="FSDatasetState",role="DataNode",service="HDFS"}',
73+
# Boolean metric
74+
'hadoop_datanode_security_enabled{kind="DataNodeInfo",role="DataNode",service="HDFS"}',
7175
# Non-special metric
7276
'hadoop_datanode_gc_count{kind="JvmMetrics",role="DataNode",service="HDFS"}',
7377
]
@@ -93,6 +97,7 @@ def check_journalnode_metrics(
9397
'hadoop_journalnode_num_active_sources{kind="MetricsSystem",role="JournalNode",service="HDFS",sub="Stats"}',
9498
# Non-special metric
9599
'hadoop_journalnode_bytes_written{kind="Journal-hdfs",role="JournalNode",service="HDFS"}',
100+
# There is no boolean metric in JournalNode.
96101
]
97102

98103
if product_version in ["3.3.4", "3.3.6"]:

0 commit comments

Comments
 (0)