Allow dashes in port names (again) (#517)

* Fix #514

* Changelog

Author: nightkr

CHANGELOG.md

@@ -7,6 +7,10 @@ All notable changes to this project will be documented in this file.
 ### Fixed
 
 - Revert changing the getting started script to use the listener class `cluster-internal` ([#492]) ([#493]).
+- Fix HDFS pods crashing on launch when any port names contain dashes ([#517]).
+
+[#493]: https://github.com/stackabletech/hdfs-operator/pull/493
+[#517]: https://github.com/stackabletech/hdfs-operator/pull/517
 
 ## [24.3.0] - 2024-03-20
 
@@ -49,7 +53,6 @@ All notable changes to this project will be documented in this file.
 [#475]: https://github.com/stackabletech/hdfs-operator/pull/475
 [#491]: https://github.com/stackabletech/hdfs-operator/pull/491
 [#492]: https://github.com/stackabletech/hdfs-operator/pull/492
-[#493]: https://github.com/stackabletech/hdfs-operator/pull/493
 [#495]: https://github.com/stackabletech/hdfs-operator/pull/495
 [#499]: https://github.com/stackabletech/hdfs-operator/pull/499
 

rust/operator-binary/src/container.rs

@@ -525,7 +525,7 @@ prepare_signal_handlers
 if [[ -d {LISTENER_VOLUME_DIR} ]]; then
     export POD_ADDRESS=$(cat {LISTENER_VOLUME_DIR}/default-address/address)
     for i in {LISTENER_VOLUME_DIR}/default-address/ports/*; do
-        export $(basename $i | tr a-z A-Z)_PORT="$(cat $i)"
+        export $(basename $i | tr a-z- A-Z_)_PORT="$(cat $i)"
     done
 fi
 {hadoop_home}/bin/hdfs {role} &

tests/templates/kuttl/smoke/30-install-hdfs.yaml.j2

@@ -66,3 +66,7 @@ spec:
                     cpu: 110m
                   limits:
                     cpu: 410m
+                ports:
+                  # https://github.com/stackabletech/hdfs-operator/issues/514
+                  - name: dashed-port
+                    containerPort: 1234