Skip to content

Commit d6a625f

Browse files
chore: Update issue templates (#1148)
* chore(issue_template): Reorder druid product bump steps * chore(issue_template): Correct the steps for stackable-base updates * chore(issue_template): Update stackable-base steps to include stackable-devel * docs: clarify difference between stackable-base and stackable-devel --------- Co-authored-by: dervoeti <lukas.krug@stackable.tech>
1 parent 01c6b05 commit d6a625f

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed

.github/ISSUE_TEMPLATE/update-base-stackable.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,17 @@ Add/Change/Remove anything that isn't applicable anymore
2727
2828
## Update tasks
2929

30-
- [ ] Update UBI version hash in the Dockerfile (`FROM`)
30+
### `stackable-base`
31+
32+
- [ ] Update `FROM ...ubi-minimal` version hash in the Dockerfile
33+
- [ ] Update `CONFIG_UTILS_VERSION`
34+
35+
### `stackable-devel`
36+
37+
- [ ] Update `FROM ...ubi-minimal` version hash in the Dockerfile
3138
- [ ] Update `RUST_DEFAULT_TOOLCHAIN_VERSION`
3239
- [ ] Update `CARGO_CYCLONEDX_CRATE_VERSION`
3340
- [ ] Update `CARGO_AUDITABLE_CRATE_VERSION`
34-
- [ ] Update `PROTOC_VERSION`
35-
- [ ] Update `CONFIG_UTILS_VERSION`
3641

3742
## Related Pull Requests
3843

.github/ISSUE_TEMPLATE/update-product-druid.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,13 @@ Add/Change/Remove anything that isn't applicable anymore
2727
2828
## Update tasks
2929

30+
- [ ] Release a new version of [druid-opa-authorizer](https://github.com/stackabletech/druid-opa-authorizer)
3031
- [ ] Update `versions.py` to reflect the agreed upon versions in the spreadsheet (including the removal of old versions).
32+
- [ ] Update the [druid-opa-authorizer](https://github.com/stackabletech/druid-opa-authorizer/) with the new set of versions.
3133
- [ ] Upload new version (see `druid/upload_new_druid_version.sh`).
3234
- [ ] Create a file: `druid/stackable/patches/x.y.z/.gitkeep`, add patches if applicable.
3335
- [ ] Delete old patch directories.
3436
- [ ] Update `versions.py` to the latest supported version of JVM (base and devel).
35-
- [ ] Update the [druid-opa-authorizer](https://github.com/stackabletech/druid-opa-authorizer/) with the new set of versions.
3637
- [ ] Check other operators (getting_started / kuttl / supported-versions) for usage of the versions. Add the PR(s) to the list below.
3738
- [ ] Ensure prerequisites are up to date (required-external-components.adoc).
3839
- [ ] Update the version in demos. Add the PR(s) to the list below.
@@ -43,11 +44,11 @@ Add/Change/Remove anything that isn't applicable anymore
4344
> Delete any items that do not apply so that all applicable items can be checked.
4445
> For example, if you add release notes to the documentation repository, you do not need the latter two criteria.
4546
47+
- [ ] _Link to [druid-opa-authorizer](https://github.com/stackabletech/druid-opa-authorizer/) PR_
4648
- [ ] _Link to the docker-images PR (product update)_
4749
- [ ] _Link to the operator PR (getting_started / kuttl / supported-versions)_
4850
- [ ] _Link to any other operator PRs (getting_started / kuttl)_
4951
- [ ] _Link to demo PR (raise against the `main` branch)_
50-
- [ ] _Link to [druid-opa-authorizer](https://github.com/stackabletech/druid-opa-authorizer/) PR_
5152
- [ ] _Link to the Release Notes PR in the documentation repo (if not a comment below)_
5253

5354
## Acceptance

stackable-base/Dockerfile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# syntax=docker/dockerfile:1.16.0@sha256:e2dd261f92e4b763d789984f6eab84be66ab4f5f08052316d8eb8f173593acf7
22
# check=error=true
33

4+
#
5+
# Base image for final stages
6+
# Should not contain any components that are not needed (or helpful) at runtime
7+
# Build time dependencies that are used in multiple images can be added to `stackable-devel` (or a derivative like `java-devel`) instead
8+
#
9+
410
FROM stackable/image/stackable-devel AS config-utils
511

612
# Find the latest version here: https://github.com/stackabletech/config-utils/tags

stackable-devel/Dockerfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33

44
#
55
# Base image for builder stages
6+
# It is intended to be used as an intermediate "workbench" layer to build components
7+
# It should not be the base for a final image to avoid shipping build time dependencies like `patchable` or `gcc`
8+
# Use `stackable-base` as a base for the final image stage instead
69
#
710

811
# Find the latest version at https://catalog.redhat.com/software/containers/ubi9/ubi-minimal/615bd9b4075b022acc111bf5?container-tabs=gti

0 commit comments

Comments
 (0)