Skip to content

Commit cc80981

Browse files
feat(superset): Add needed Python libs for OIDC (#799)
* Adding path for Superset 4.0.2 oidc logout * Adding libs for oidc logout to superset/Dockerfile * superset: Removing patch due to operator changes * Making Flask_OIDC and Flask-OpenID accessable to all superset versions * Removing slash * Adding nicks suggestion Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> * Making hadolint happy * fixing typo * ignoring another info * adding comments for hadolint ignore * Resolving Hadolint SC2102 Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com> * Making hadolint happy again --------- Co-authored-by: Nick <10092581+NickLarsenNZ@users.noreply.github.com>
1 parent dd7d6ed commit cc80981

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

superset/Dockerfile

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ RUN microdnf update \
3838
&& microdnf clean all && \
3939
rm -rf /var/cache/yum
4040

41+
# DL3042 false-positive, --no-chache-dir is specified a few lines below.
42+
# See https://github.com/hadolint/hadolint/issues/1042.
43+
# hadolint ignore=DL3042
4144
RUN python3 -m venv /stackable/app \
4245
&& source /stackable/app/bin/activate \
4346
&& pip install \
@@ -55,7 +58,12 @@ RUN python3 -m venv /stackable/app \
5558
statsd \
5659
pydruid \
5760
python-ldap \
58-
trino[sqlalchemy] \
61+
'trino[sqlalchemy]' \
62+
# Add optional dependencies for use in custom Superset configurations.
63+
# Since https://github.com/stackabletech/superset-operator/pull/530
64+
# admins can add custom configuration to superset_conf.py.
65+
Flask_OIDC==2.2.0 \
66+
Flask-OpenID==1.3.1\
5967
# Redhat has removed `tzdata` from the ubi-minimal images: see https://bugzilla.redhat.com/show_bug.cgi?id=2223028.
6068
# Superset relies on ZoneInfo (https://docs.python.org/3/library/zoneinfo.html#data-sources) to resolve time zones, and this is done
6169
# by searching first under `TZPATH` (which is empty due to the point above) or for the tzdata python package.
@@ -66,7 +74,7 @@ RUN python3 -m venv /stackable/app \
6674
--upgrade \
6775
python-json-logger \
6876
cyclonedx-bom \
69-
&& if [ ! -z "$AUTHLIB" ]; then pip install Authlib==${AUTHLIB}; fi
77+
&& if [ -n "$AUTHLIB" ]; then pip install Authlib==${AUTHLIB}; fi
7078

7179
COPY superset/stackable/patches /patches
7280
RUN /patches/apply_patches.sh ${PRODUCT}

0 commit comments

Comments
 (0)