Skip to content

Commit 3824d0f

Browse files
authored
Revert "chore(zookeeper): remove jmx exporter (#1161)" (#1175)
This reverts commit fcdb3dc.
1 parent fcdb3dc commit 3824d0f

File tree

4 files changed

+48
-2
lines changed

4 files changed

+48
-2
lines changed

CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ All notable changes to this project will be documented in this file.
124124
- kafka: Remove `3.7.1` and `3.8.0` ([#1117]).
125125
- spark-connect-client: Remove `3.5.5` ([#1142]).
126126
- spark-k8s: Remove the JMX exporter jar ([#1157]).
127-
- zookeeper: Remove jmx exporter ([#1161]).
128127

129128
[nifi-iceberg-bundle]: https://github.com/stackabletech/nifi-iceberg-bundle
130129
[#1025]: https://github.com/stackabletech/docker-images/pull/1025
@@ -189,7 +188,6 @@ All notable changes to this project will be documented in this file.
189188
[#1157]: https://github.com/stackabletech/docker-images/pull/1157
190189
[#1163]: https://github.com/stackabletech/docker-images/pull/1163
191190
[#1165]: https://github.com/stackabletech/docker-images/pull/1165
192-
[#1161]: https://github.com/stackabletech/docker-images/pull/1161
193191

194192
## [25.3.0] - 2025-03-21
195193

zookeeper/Dockerfile

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@
77
FROM stackable/image/java-devel AS builder
88

99
ARG PRODUCT
10+
ARG JMX_EXPORTER
1011
ARG STACKABLE_USER_UID
1112

1213
# Copy patches into the builder
1314
COPY --chown=${STACKABLE_USER_UID}:0 zookeeper/stackable/patches/patchable.toml /stackable/src/zookeeper/stackable/patches/patchable.toml
1415
COPY --chown=${STACKABLE_USER_UID}:0 zookeeper/stackable/patches/${PRODUCT} /stackable/src/zookeeper/stackable/patches/${PRODUCT}
16+
# Copy JMX config into the builder
17+
COPY --chown=${STACKABLE_USER_UID}:0 zookeeper/stackable/jmx /stackable/jmx
1518

1619
USER ${STACKABLE_USER_UID}
1720
WORKDIR /stackable
@@ -35,6 +38,12 @@ mv zookeeper-assembly/target/bom.json /stackable/apache-zookeeper-${PRODUCT}-bin
3538
rm -rf /stackable/apache-zookeeper-${PRODUCT}-bin/docs
3639
rm /stackable/apache-zookeeper-${PRODUCT}-bin/README_packaging.md
3740

41+
# Download the JMX exporter jar from our own repo
42+
curl "https://repo.stackable.tech/repository/packages/jmx-exporter/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar" \
43+
-o "/stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar"
44+
chmod +x "/stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar"
45+
ln -s "/stackable/jmx/jmx_prometheus_javaagent-${JMX_EXPORTER}.jar" /stackable/jmx/jmx_prometheus_javaagent.jar
46+
3847
# set correct groups
3948
chmod -R g=u /stackable
4049
EOF
@@ -63,6 +72,7 @@ LABEL \
6372
# Copy over the ZooKeeper binary folder
6473
COPY --chown=${STACKABLE_USER_UID}:0 --from=builder /stackable/apache-zookeeper-${PRODUCT}-bin /stackable/apache-zookeeper-${PRODUCT}-bin/
6574
COPY --chown=${STACKABLE_USER_UID}:0 --from=builder /stackable/zookeeper-${PRODUCT}-src.tar.gz /stackable
75+
COPY --chown=${STACKABLE_USER_UID}:0 --from=builder /stackable/jmx /stackable/jmx/
6676
COPY zookeeper/licenses /licenses
6777

6878
RUN <<EOF
@@ -79,6 +89,7 @@ ln -s /stackable/apache-zookeeper-${PRODUCT}-bin/ /stackable/zookeeper
7989
chown -h ${STACKABLE_USER_UID}:0 /stackable/zookeeper
8090

8191
# fix missing permissions
92+
chmod g=u /stackable/jmx
8293
chmod g=u /stackable/apache-zookeeper-${PRODUCT}-bin/
8394
EOF
8495

zookeeper/stackable/jmx/server.yaml

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
---
2+
rules:
3+
# replicated Zookeeper
4+
- pattern: "org.apache.ZooKeeperService<name0=ReplicatedServer_id(\\d+)><>(\\w+)"
5+
name: "zookeeper_$2"
6+
type: GAUGE
7+
- pattern: "org.apache.ZooKeeperService<name0=ReplicatedServer_id(\\d+), name1=replica.(\\d+)><>(\\w+)"
8+
name: "zookeeper_$3"
9+
type: GAUGE
10+
labels:
11+
replicaId: "$2"
12+
- pattern: "org.apache.ZooKeeperService<name0=ReplicatedServer_id(\\d+), name1=replica.(\\d+), name2=(\\w+)><>(Packets\\w+)"
13+
name: "zookeeper_$4"
14+
type: COUNTER
15+
labels:
16+
replicaId: "$2"
17+
memberType: "$3"
18+
- pattern: "org.apache.ZooKeeperService<name0=ReplicatedServer_id(\\d+), name1=replica.(\\d+), name2=(\\w+)><>(\\w+)"
19+
name: "zookeeper_$4"
20+
type: GAUGE
21+
labels:
22+
replicaId: "$2"
23+
memberType: "$3"
24+
- pattern: "org.apache.ZooKeeperService<name0=ReplicatedServer_id(\\d+), name1=replica.(\\d+), name2=(\\w+), name3=(\\w+)><>(\\w+)"
25+
name: "zookeeper_$4_$5"
26+
type: GAUGE
27+
labels:
28+
replicaId: "$2"
29+
memberType: "$3"
30+
# standalone Zookeeper
31+
- pattern: "org.apache.ZooKeeperService<name0=StandaloneServer_port(\\d+)><>(\\w+)"
32+
type: GAUGE
33+
name: "zookeeper_$2"
34+
- pattern: "org.apache.ZooKeeperService<name0=StandaloneServer_port(\\d+), name1=InMemoryDataTree><>(\\w+)"
35+
type: GAUGE
36+
name: "zookeeper_$2"

zookeeper/versions.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@
77
# zookeeper: Execution spotbugs of goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:spotbugs failed: Java
88
# returned: 1 -> [Help 1]
99
"java-devel": "11",
10+
"jmx_exporter": "1.3.0",
1011
},
1112
]

0 commit comments

Comments
 (0)