Skip to content

Commit d7ddbe7

Browse files
authored
fix(stack/trino-superset-s3): Use Minio with TLS (#174)
* chore(stack): Render helm-chart for minio with tls * chore(stack/minio-tls): Override command to copy certs to the correct names * chore(stack/trino-superset-s3): Enable TLS for S3Connection * chore(stack/trino-superset-s3): Use rendered mino-tls
1 parent 8468d5d commit d7ddbe7

File tree

6 files changed

+750
-1
lines changed

6 files changed

+750
-1
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
default_language_version:
33
node: system
44

5+
exclude: '^stacks/_templates/minio-tls/rendered-chart\.yaml$'
6+
57
repos:
68
- repo: https://github.com/pre-commit/pre-commit-hooks
79
rev: 2c9f875913ee60ca25ce70243dc24d5b6415598c # 4.6.0

stacks/_templates/minio-tls/README.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# MinIO with TLS from secret-operator
2+
3+
MinIO has a severe limitation whereby the TLS certificates must be named `public.crt`
4+
and `private.key`. This goes against Kubernetes naming of `tls.crt` and `tls.key`.
5+
6+
The upstream minio chart is also too limited:
7+
8+
- No way to add initContainers (to rename cert files in a shared volume).
9+
- No way to edit the container command (to rename cert files before starting minio).
10+
11+
Therefore, we will render the upstream chart here, and then apply the necessary
12+
customizations on top.
13+
14+
```yaml
15+
helm template minio minio/minio -f values.yaml > rendered-chart.yaml
16+
```

0 commit comments

Comments
 (0)