Skip to content

Commit d4b1342

Browse files
author
Maximilien Naveau
committed
cleaning and renaming a bunch of operator in order to get consistent naming.
1 parent e084942 commit d4b1342

File tree

7 files changed

+17
-18
lines changed

7 files changed

+17
-18
lines changed

src/dynamic_graph/sot/core/math_small_entities.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
HomoToTwist, Inverse_of_matrix, Inverse_of_matrixHomo,
1212
Inverse_of_matrixrotation, Inverse_of_matrixtwist, Inverse_of_unitquat,
1313
MatrixDiagonal, MatrixHomoToPose, MatrixHomoToPoseQuaternion,
14-
PoseQuatToMatrixHomo, MatrixHomoToPoseRollPitchYaw, MatrixHomoToPoseUTheta,
15-
MatrixToHomo, MatrixToQuaternion, MatrixToRPY, MatrixToUTheta,
16-
MatrixHomoToSE3Vector, SE3VectorToMatrixHomo, MatrixTranspose,
17-
Multiply_double_vector, Multiply_matrix_vector,
14+
PoseQuaternionToMatrixHomo, MatrixHomoToPoseRollPitchYaw,
15+
MatrixHomoToPoseUTheta, MatrixToHomo, MatrixToQuaternion, MatrixToRPY,
16+
MatrixToUTheta, MatrixHomoToSE3Vector, SE3VectorToMatrixHomo,
17+
MatrixTranspose, Multiply_double_vector, Multiply_matrix_vector,
1818
Multiply_matrixTwist_vector, Multiply_matrixHomo_vector,
1919
Multiply_of_double, Multiply_of_matrix, Multiply_of_matrixHomo,
2020
Multiply_of_matrixrotation, Multiply_of_matrixtwist,

src/dynamic_graph/sot/core/meta_task_posture.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from dynamic_graph.sot.core.matrix_util import matrixToTuple, vectorToTuple
55
from dynamic_graph.sot.core.meta_task_6d import toFlags # kept for backward compatibility
66
from dynamic_graph.sot.core.meta_tasks import setGain
7-
from dynamic_graph.sot.core.sot import Task
7+
from dynamic_graph.sot.core.task import Task
88
from numpy import identity, matrix, zeros
99

1010

src/dynamic_graph/sot/core/meta_task_visual_point.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from dynamic_graph.sot.core.gain_adaptive import GainAdaptive
44
from dynamic_graph.sot.core.meta_tasks import setGain
55
from dynamic_graph.sot.core.op_point_modifier import OpPointModifier
6-
from dynamic_graph.sot.core.sot import Task
6+
from dynamic_graph.sot.core.task import Task
77
from dynamic_graph.sot.core.visual_point_projecter import VisualPointProjecter
88

99

src/matrix/operator-python-module-py.cc

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,11 @@ BOOST_PYTHON_MODULE(wrap)
9999
/* --- SE3/SO3 conversions ----------------------------------------------- */
100100
/* ----------------------------------------------------------------------- */
101101

102-
exposeUnaryOp < HomogeneousMatrixToVector> ();
103102
exposeUnaryOp < SkewSymToVector> ();
104103
exposeUnaryOp < PoseUThetaToMatrixHomo> ();
105-
exposeUnaryOp < HomogeneousMatrixToVector> ();
106-
exposeUnaryOp < HomogeneousMatrixToSE3Vector> ();
107-
exposeUnaryOp < SE3VectorToHomogeneousMatrix> ();
104+
exposeUnaryOp < MatrixHomoToPoseUTheta> ();
105+
exposeUnaryOp < MatrixHomoToSE3Vector> ();
106+
exposeUnaryOp < SE3VectorToMatrixHomo> ();
108107
exposeUnaryOp < PoseQuaternionToMatrixHomo> ();
109108
exposeUnaryOp < MatrixHomoToPoseQuaternion> ();
110109
exposeUnaryOp < MatrixHomoToPoseRollPitchYaw> ();

src/matrix/operator.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,13 @@ REGISTER_UNARY_OP(InverserQuaternion, Inverse_of_unitquat);
5757
/* --- SE3/SO3 conversions ----------------------------------------------- */
5858
/* ----------------------------------------------------------------------- */
5959

60-
REGISTER_UNARY_OP(HomogeneousMatrixToVector, MatrixHomoToPoseUTheta);
61-
REGISTER_UNARY_OP(HomogeneousMatrixToSE3Vector, MatrixHomoToSE3Vector);
62-
REGISTER_UNARY_OP(SE3VectorToHomogeneousMatrix, SE3VectorToMatrixHomo);
60+
REGISTER_UNARY_OP(MatrixHomoToPoseUTheta, MatrixHomoToPoseUTheta);
61+
REGISTER_UNARY_OP(MatrixHomoToSE3Vector, MatrixHomoToSE3Vector);
62+
REGISTER_UNARY_OP(SE3VectorToMatrixHomo, SE3VectorToMatrixHomo);
6363
REGISTER_UNARY_OP(SkewSymToVector, SkewSymToVector);
6464
REGISTER_UNARY_OP(PoseUThetaToMatrixHomo, PoseUThetaToMatrixHomo);
6565
REGISTER_UNARY_OP(MatrixHomoToPoseQuaternion, MatrixHomoToPoseQuaternion);
66-
REGISTER_UNARY_OP(PoseQuaternionToMatrixHomo, PoseQuatToMatrixHomo);
66+
REGISTER_UNARY_OP(PoseQuaternionToMatrixHomo, PoseQuaternionToMatrixHomo);
6767
REGISTER_UNARY_OP(MatrixHomoToPoseRollPitchYaw, MatrixHomoToPoseRollPitchYaw);
6868
REGISTER_UNARY_OP(PoseRollPitchYawToMatrixHomo, PoseRollPitchYawToMatrixHomo);
6969
REGISTER_UNARY_OP(PoseRollPitchYawToPoseUTheta, PoseRollPitchYawToPoseUTheta);

src/matrix/operator.hh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ struct InverserQuaternion
278278
/* --- SE3/SO3 conversions ----------------------------------------------- */
279279
/* ----------------------------------------------------------------------- */
280280

281-
struct HomogeneousMatrixToVector
281+
struct MatrixHomoToPoseUTheta
282282
: public UnaryOpHeader<MatrixHomogeneous, dg::Vector> {
283283
inline void operator()(const MatrixHomogeneous &M, dg::Vector &res) {
284284
res.resize(6);
@@ -310,7 +310,7 @@ struct PoseUThetaToMatrixHomo
310310
}
311311
};
312312

313-
struct SE3VectorToHomogeneousMatrix
313+
struct SE3VectorToMatrixHomo
314314
: public UnaryOpHeader<dg::Vector, MatrixHomogeneous> {
315315
void operator()(const dg::Vector &vect, MatrixHomogeneous &Mres) {
316316
Mres.translation() = vect.head<3>();
@@ -320,7 +320,7 @@ struct SE3VectorToHomogeneousMatrix
320320
}
321321
};
322322

323-
struct HomogeneousMatrixToSE3Vector
323+
struct MatrixHomoToSE3Vector
324324
: public UnaryOpHeader<MatrixHomogeneous, dg::Vector> {
325325
void operator()(const MatrixHomogeneous &M, dg::Vector &res) {
326326
res.resize(12);

tests/matrix/test_operator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ BOOST_AUTO_TEST_CASE(matrixHomo_poseQuaternion) {
199199
test_impl<MatrixHomoToPoseQuaternion, PoseQuaternionToMatrixHomo>();
200200
}
201201
BOOST_AUTO_TEST_CASE(matrixHomo_se3Vector) {
202-
test_impl<HomogeneousMatrixToSE3Vector, SE3VectorToHomogeneousMatrix>();
202+
test_impl<MatrixHomoToSE3Vector, SE3VectorToMatrixHomo>();
203203
}
204204

205205
BOOST_AUTO_TEST_SUITE_END()

0 commit comments

Comments
 (0)