Skip to content

Commit b779239

Browse files
fbaillyolivier-stasse
authored andcommitted
removed iostream from robot-utils header, removed #define from robot-utils header. Added return to base_sot_to_urdf method that lacked it
1 parent 1cc827a commit b779239

File tree

2 files changed

+8
-21
lines changed

2 files changed

+8
-21
lines changed

include/sot/core/robot-utils.hh

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -11,25 +11,10 @@
1111
#ifndef __sot_torque_control_common_H__
1212
#define __sot_torque_control_common_H__
1313

14-
/* --------------------------------------------------------------------- */
15-
/* --- API ------------------------------------------------------------- */
16-
/* --------------------------------------------------------------------- */
17-
18-
#if defined (WIN32)
19-
# if defined (hrp2_common_EXPORTS)
20-
# define ROBOT_UTILS_COMMON_EXPORT __declspec(dllexport)
21-
# else
22-
# define ROBOT_UTILS_COMMON_EXPORT __declspec(dllimport)
23-
# endif
24-
#else
25-
# define ROBOT_UTILS_COMMON_EXPORT
26-
#endif
27-
2814

2915
/* --------------------------------------------------------------------- */
3016
/* --- INCLUDE --------------------------------------------------------- */
3117
/* --------------------------------------------------------------------- */
32-
#include <iostream>
3318
#include <dynamic-graph/linear-algebra.h>
3419
#include <dynamic-graph/signal-helper.h>
3520
#include <sot/core/matrix-geometry.hh>
@@ -44,7 +29,7 @@ using namespace dg;
4429
namespace dynamicgraph {
4530
namespace sot {
4631

47-
struct JointLimits
32+
struct SOT_CORE_EXPORT JointLimits
4833
{
4934
double upper;
5035
double lower;
@@ -62,7 +47,7 @@ namespace dynamicgraph {
6247

6348
typedef Eigen::VectorXd::Index Index;
6449

65-
struct ForceLimits
50+
struct SOT_CORE_EXPORT ForceLimits
6651
{
6752
Eigen::VectorXd upper;
6853
Eigen::VectorXd lower;
@@ -81,7 +66,7 @@ namespace dynamicgraph {
8166
};
8267

8368

84-
struct ForceUtil
69+
struct SOT_CORE_EXPORT ForceUtil
8570
{
8671
std::map<Index,ForceLimits> m_force_id_to_limits;
8772
std::map<std::string,Index> m_name_to_force_id;
@@ -151,9 +136,9 @@ namespace dynamicgraph {
151136

152137
void display(std::ostream & out) const;
153138

154-
}; // struct ForceUtil
139+
}; // struct ForceUtil
155140

156-
struct FootUtil
141+
struct SOT_CORE_EXPORT FootUtil
157142
{
158143
/// Position of the foot soles w.r.t. the frame of the foot
159144
dynamicgraph::Vector m_Right_Foot_Sole_XYZ;
@@ -164,7 +149,7 @@ namespace dynamicgraph {
164149
void display(std::ostream & os) const;
165150
};
166151

167-
struct RobotUtil
152+
struct SOT_CORE_EXPORT RobotUtil
168153
{
169154
public:
170155

src/robot-utils.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* See license file.
88
*/
99

10+
#include <iostream>
1011
#include <sot/core/robot-utils.hh>
1112
#include <sot/core/debug.hh>
1213
#include <dynamic-graph/factory.h>
@@ -390,6 +391,7 @@ namespace dynamicgraph
390391
base_sot_to_urdf(q_sot.head<6>(), q_urdf.head<7>());
391392
joints_sot_to_urdf(q_sot.tail(m_nbJoints),
392393
q_urdf.tail(m_nbJoints));
394+
return true;
393395

394396

395397
}

0 commit comments

Comments
 (0)