Skip to content

Commit af403dc

Browse files
committed
[CMake] sync submodule and its use
1 parent d94aaee commit af403dc

File tree

3 files changed

+18
-26
lines changed

3 files changed

+18
-26
lines changed

CMakeLists.txt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,19 @@ CHECK_MINIMAL_CXX_STANDARD(11 ENFORCE)
3838
ADD_PROJECT_DEPENDENCY(dynamic-graph REQUIRED PKG_CONFIG_REQUIRES dynamic-graph)
3939
ADD_PROJECT_DEPENDENCY(pinocchio REQUIRED PKG_CONFIG_REQUIRES pinocchio)
4040
ADD_PROJECT_DEPENDENCY(example-robot-data)
41-
SET(BOOST_COMPONENTS filesystem system thread program_options
42-
unit_test_framework regex)
41+
ADD_PROJECT_DEPENDENCY(Boost REQUIRED COMPONENTS regex)
42+
IF(BUILD_TESTING)
43+
FIND_PACKAGE(Boost REQUIRED COMPONENTS unit_test_framework program_options)
44+
ENDIF()
4345

4446
IF(BUILD_PYTHON_INTERFACE)
4547
FINDPYTHON()
4648
STRING(REGEX REPLACE "-" "_" PYTHON_DIR ${CUSTOM_HEADER_DIR})
4749
ADD_PROJECT_DEPENDENCY(dynamic-graph-python REQUIRED
4850
PKG_CONFIG_REQUIRES dynamic-graph-python)
49-
ADD_PROJECT_DEPENDENCY(dynamic-graph-python REQUIRED PKG_CONFIG_REQUIRES dynamic-graph-python)
51+
SEARCH_FOR_BOOST_PYTHON(REQUIRED)
5052
ENDIF(BUILD_PYTHON_INTERFACE)
5153

52-
SEARCH_FOR_BOOST()
53-
5454
# Verbosity level
5555
IF(NOT (\"${CMAKE_VERBOSITY_LEVEL}\" STREQUAL \"\"))
5656
ADD_DEFINITIONS(-DVP_DEBUG_MODE=${CMAKE_VERBOSITY_LEVEL} -DVP_DEBUG)
@@ -172,9 +172,7 @@ SET(${PROJECT_NAME}_SOURCES
172172
ADD_LIBRARY(${PROJECT_NAME} SHARED
173173
${${PROJECT_NAME}_SOURCES} ${${PROJECT_NAME}_HEADERS})
174174
TARGET_INCLUDE_DIRECTORIES(${PROJECT_NAME} PUBLIC $<INSTALL_INTERFACE:include>)
175-
TARGET_INCLUDE_DIRECTORIES(${PROJECT_NAME}
176-
SYSTEM PUBLIC ${Boost_INCLUDE_DIRS})
177-
TARGET_LINK_LIBRARIES(${PROJECT_NAME} ${Boost_LIBRARIES}
175+
TARGET_LINK_LIBRARIES(${PROJECT_NAME} PUBLIC Boost::regex
178176
dynamic-graph::dynamic-graph pinocchio::pinocchio)
179177
180178
IF(SUFFIX_SO_VERSION)

src/CMakeLists.txt

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ FOREACH(plugin ${plugins})
9595
SET_TARGET_PROPERTIES(${LIBRARY_NAME} PROPERTIES SOVERSION ${PROJECT_VERSION})
9696
ENDIF(SUFFIX_SO_VERSION)
9797

98-
TARGET_LINK_LIBRARIES(${LIBRARY_NAME} ${PROJECT_NAME} ${${LIBRARY_NAME}_deps})
98+
TARGET_LINK_LIBRARIES(${LIBRARY_NAME} PUBLIC ${PROJECT_NAME} ${${LIBRARY_NAME}_deps})
9999

100100
IF(NOT INSTALL_PYTHON_INTERFACE_ONLY)
101101
INSTALL(TARGETS ${LIBRARY_NAME} EXPORT ${TARGETS_EXPORT_NAME}
@@ -160,12 +160,10 @@ IF(BUILD_PYTHON_INTERFACE)
160160
# Robot_utils_sot_py PYTHON module *
161161
# **********************************
162162
ADD_LIBRARY(robot_utils_sot_py SHARED tools/robot-utils-py.cpp)
163-
TARGET_INCLUDE_DIRECTORIES(robot_utils_sot_py SYSTEM PUBLIC ${PYTHON_INCLUDE_DIRS})
164-
TARGET_LINK_LIBRARIES(robot_utils_sot_py
165-
${Boost_LIBRARIES} ${PYTHON_LIBRARIES} ${PROJECT_NAME}
166-
dynamic-graph::dynamic-graph pinocchio::pinocchio)
167-
TARGET_INCLUDE_DIRECTORIES(robot_utils_sot_py PUBLIC pinocchio::pinocchio)
168-
TARGET_LINK_BOOST_PYTHON(robot_utils_sot_py)
163+
TARGET_INCLUDE_DIRECTORIES(robot_utils_sot_py SYSTEM PUBLIC ${PYTHON_INCLUDE_DIR})
164+
TARGET_LINK_LIBRARIES(robot_utils_sot_py PUBLIC
165+
${PYTHON_LIBRARIES} ${PROJECT_NAME})
166+
TARGET_LINK_BOOST_PYTHON(robot_utils_sot_py PRIVATE)
169167
SET_TARGET_PROPERTIES(robot_utils_sot_py PROPERTIES PREFIX "")
170168
INSTALL(TARGETS robot_utils_sot_py DESTINATION "${PYTHON_SITELIB}/dynamic_graph/${PYTHON_DIR}")
171169
ENDIF(BUILD_PYTHON_INTERFACE)

tests/CMakeLists.txt

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -104,25 +104,21 @@ IF(UNIX)
104104
ADD_LIBRARY(pluginabstract SHARED tools/plugin.cc)
105105

106106
ADD_EXECUTABLE(test_abstract_interface tools/test_abstract_interface.cpp)
107-
TARGET_LINK_LIBRARIES(test_abstract_interface
108-
pluginabstract ${CMAKE_DL_LIBS} ${Boost_LIBRARIES})
109-
TARGET_INCLUDE_DIRECTORIES(test_abstract_interface
110-
SYSTEM PUBLIC ${Boost_INCLUDE_DIRS})
111-
107+
TARGET_LINK_LIBRARIES(test_abstract_interface PRIVATE
108+
Boost::program_options
109+
pluginabstract ${CMAKE_DL_LIBS})
112110
ENDIF(UNIX)
113111

114112
FOREACH(path ${tests})
115113
GET_FILENAME_COMPONENT(test ${path} NAME)
116114
ADD_UNIT_TEST(${test} ${path}.cpp)
117115

118-
TARGET_LINK_LIBRARIES(${test}
119-
PUBLIC
120-
${PROJECT_NAME}
121-
${TEST_${test}_LIBS} ${TEST_${test}_EXT_LIBS}
122-
dynamic-graph::dynamic-graph)
116+
TARGET_LINK_LIBRARIES(${test} PRIVATE ${PROJECT_NAME}
117+
Boost::unit_test_framework
118+
${TEST_${test}_LIBS} ${TEST_${test}_EXT_LIBS})
123119

124120
IF(UNIX)
125-
TARGET_LINK_LIBRARIES(${test} PUBLIC ${CMAKE_DL_LIBS})
121+
TARGET_LINK_LIBRARIES(${test} PRIVATE ${CMAKE_DL_LIBS})
126122
ENDIF(UNIX)
127123
ENDFOREACH(path ${tests})
128124

0 commit comments

Comments
 (0)