Merge pull request #264 from geomatician/main

Use map instead of foreach/push

Author: geomatician

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [0.5.0] - 2022-05-20
+
+### Changed
+
+- Used map instead of foreach/push in api.js file
+
 ## [0.5.0] - 2022-05-18
 
 ### Added

src/lib/api.js

@@ -184,16 +184,16 @@ const extractSortby = function (params) {
   if (sortby) {
     if (typeof sortby === 'string') {
       // GET request - different syntax
-      sortbyRules = []
       const sortbys = sortby.split(',')
-      sortbys.forEach((sortbyRule) => {
+
+      sortbyRules = sortbys.map((sortbyRule) => {
         if (sortbyRule[0] === '-') {
-          sortbyRules.push({ field: sortbyRule.slice(1), direction: 'desc' })
-        } else if (sortbyRule[0] === '+') {
-          sortbyRules.push({ field: sortbyRule.slice(1), direction: 'asc' })
-        } else {
-          sortbyRules.push({ field: sortbyRule, direction: 'asc' })
+          return { field: sortbyRule.slice(1), direction: 'desc' }
+        }
+        if (sortbyRule[0] === '+') {
+          return { field: sortbyRule.slice(1), direction: 'asc' }
         }
+        return { field: sortbyRule, direction: 'asc' }
       })
     } else {
       // POST request