refactor: use starlette.testclient.TestClient

Author: alukach

tests/api/test_links_with_root_path.py

@@ -1,7 +1,7 @@
 import importlib
 
 import pytest
-from httpx import ASGITransport, AsyncClient
+from starlette.testclient import TestClient
 
 from stac_fastapi.pgstac.db import close_db_connection, connect_to_db
 
@@ -44,53 +44,53 @@ async def app_with_root_path(database, monkeypatch):
 
 
 @pytest.fixture(scope="function")
-async def client_with_root_path(app_with_root_path):
-    async with AsyncClient(
-        transport=ASGITransport(app=app_with_root_path),
-        base_url=base_url,
+def client_with_root_path(app_with_root_path):
+    with TestClient(
+        app_with_root_path,
+        root_path=root_path_value,
     ) as c:
         yield c
 
 
 @pytest.fixture(scope="function")
-async def loaded_client(client_with_root_path, load_test_data):
+def loaded_client(client_with_root_path, load_test_data):
     col = load_test_data("test_collection.json")
-    resp = await client_with_root_path.post(
+    resp = client_with_root_path.post(
         "/collections",
         json=col,
     )
     assert resp.status_code == 201
     item = load_test_data("test_item.json")
-    resp = await client_with_root_path.post(
+    resp = client_with_root_path.post(
         f"/collections/{col['id']}/items",
         json=item,
     )
     assert resp.status_code == 201
     item = load_test_data("test_item2.json")
-    resp = await client_with_root_path.post(
+    resp = client_with_root_path.post(
         f"/collections/{col['id']}/items",
         json=item,
     )
     assert resp.status_code == 201
     yield client_with_root_path
 
 
-async def test_search_links_are_valid(loaded_client):
-    resp = await loaded_client.get("/search?limit=1")
+def test_search_links_are_valid(loaded_client):
+    resp = loaded_client.get("/search?limit=1")
     assert resp.status_code == 200
     response_json = resp.json()
     assert_links_href(response_json.get("links", []), base_url)
 
 
-async def test_collection_links_are_valid(loaded_client):
-    resp = await loaded_client.get("/collections?limit=1")
+def test_collection_links_are_valid(loaded_client):
+    resp = loaded_client.get("/collections?limit=1")
     assert resp.status_code == 200
     response_json = resp.json()
     assert_links_href(response_json.get("links", []), base_url)
 
 
-async def test_items_collection_links_are_valid(loaded_client):
-    resp = await loaded_client.get("/collections/test-collection/items?limit=1")
+def test_items_collection_links_are_valid(loaded_client):
+    resp = loaded_client.get("/collections/test-collection/items?limit=1")
     assert resp.status_code == 200
     response_json = resp.json()
     assert_links_href(response_json.get("links", []), base_url)