Remove unused pop_if_none argument

Author: duckontheweb

pystac/common_metadata.py

@@ -29,21 +29,19 @@ class CommonMetadata:
     def __init__(self, object: Union["Asset", "Item"]):
         self.object = object
 
-    def _set_field(
-        self, prop_name: str, v: Optional[Any], pop_if_none: bool = True
-    ) -> None:
+    def _set_field(self, prop_name: str, v: Optional[Any]) -> None:
         if hasattr(self.object, prop_name):
             setattr(self.object, prop_name, v)
         elif hasattr(self.object, "properties"):
             item = cast("Item", self.object)
-            if pop_if_none and v is None:
+            if v is None:
                 item.properties.pop(prop_name, None)
             else:
                 item.properties[prop_name] = v
         elif hasattr(self.object, "extra_fields") and isinstance(
             self.object.extra_fields, Dict
         ):
-            if pop_if_none and v is None:
+            if v is None:
                 self.object.extra_fields.pop(prop_name, None)
             else:
                 self.object.extra_fields[prop_name] = v

tests/test_common_metadata.py

@@ -115,7 +115,9 @@ def test_common_metadata_providers(self) -> None:
                 "url": "https://cool-sat.com/",
             }
         ]
-        providers_object_list = [pystac.Provider.from_dict(d) for d in providers_dict_list]
+        providers_object_list = [
+            pystac.Provider.from_dict(d) for d in providers_dict_list
+        ]
 
         example_providers_dict_list: List[Dict[str, Any]] = [
             {
@@ -321,7 +323,9 @@ def test_end_datetime(self) -> None:
         analytic_cm.end_datetime = set_value
 
         self.assertEqual(analytic_cm.end_datetime, set_value)
-        self.assertEqual(analytic.to_dict()["end_datetime"], utils.datetime_to_str(set_value))
+        self.assertEqual(
+            analytic.to_dict()["end_datetime"], utils.datetime_to_str(set_value)
+        )
 
     def test_license(self) -> None:
         item = self.item.clone()
@@ -511,7 +515,9 @@ def test_created(self) -> None:
         analytic_cm.created = set_value
 
         self.assertEqual(analytic_cm.created, set_value)
-        self.assertEqual(analytic.to_dict()["created"], utils.datetime_to_str(set_value))
+        self.assertEqual(
+            analytic.to_dict()["created"], utils.datetime_to_str(set_value)
+        )
 
     def test_updated(self) -> None:
         item = self.item.clone()
@@ -533,5 +539,6 @@ def test_updated(self) -> None:
         analytic_cm.updated = set_value
 
         self.assertEqual(analytic_cm.updated, set_value)
-        self.assertEqual(analytic.to_dict()["updated"], utils.datetime_to_str(set_value))
-
+        self.assertEqual(
+            analytic.to_dict()["updated"], utils.datetime_to_str(set_value)
+        )