Merge pull request #562 from stac-utils/fix/rde/types

Fix some type issues exposed via the API

Author: Jon Duckworth

CHANGELOG.md

@@ -36,6 +36,8 @@
 
 - Added `Collections` as a type that can be extended for extensions whose fields can appear in collection summaries ([#547](https://github.com/stac-utils/pystac/pull/547))
 - Allow resolved self links when getting an object's self href ([#555](https://github.com/stac-utils/pystac/pull/555))
+- Fixed type annotation on SummariesLabelExtension.label_properties setter ([#562](https://github.com/stac-utils/pystac/pull/562))
+- Allow comparable types with alternate parameter naming of __lt__ method to pass structural type linting for RangeSummary ([#562](https://github.com/stac-utils/pystac/pull/562))
 
 ### Deprecated
 

pystac/extensions/label.py

@@ -722,7 +722,7 @@ def label_properties(self) -> Optional[List[str]]:
         return self.summaries.get_list(PROPERTIES_PROP)
 
     @label_properties.setter
-    def label_properties(self, v: Optional[List[LabelClasses]]) -> None:
+    def label_properties(self, v: Optional[List[str]]) -> None:
         self._set_summary(PROPERTIES_PROP, v)
 
     @property

pystac/summaries.py

@@ -30,15 +30,31 @@
 from abc import abstractmethod
 
 
-class Comparable(Protocol):
-    """Protocol for annotating comparable types."""
+class _Comparable_x(Protocol):
+    """Protocol for annotating comparable types.
+
+    For matching __lt__ that takes an 'x' parameter
+    (e.g. float)
+    """
 
     @abstractmethod
     def __lt__(self: "T", x: "T") -> bool:
         return NotImplemented
 
 
-T = TypeVar("T", bound=Comparable)
+class _Comparable_other(Protocol):
+    """Protocol for annotating comparable types.
+
+    For matching __lt___ that takes an 'other' parameter
+    (e.g. datetime)
+    """
+
+    @abstractmethod
+    def __lt__(self: "T", other: "T") -> bool:
+        return NotImplemented
+
+
+T = TypeVar("T", bound=Union[_Comparable_x, _Comparable_other])
 
 
 class RangeSummary(Generic[T]):