feat: Warn about casting an expression to its inferred type

Author: l0b0

mypy.ini

@@ -4,3 +4,4 @@ disallow_untyped_defs = True
 ignore_missing_imports = True
 no_implicit_optional = True
 show_error_codes = True
+warn_redundant_casts = True

pystac/catalog.py

@@ -798,7 +798,7 @@ def map_items(
             to the item_mapper function.
         """
 
-        new_cat = cast(Catalog, self.full_copy())
+        new_cat = self.full_copy()
 
         def process_catalog(catalog: Catalog) -> None:
             for child in catalog.get_children():

pystac/serialization/common_properties.py

@@ -71,7 +71,7 @@ def merge_common_properties(
             (link for link in links if link["rel"] == pystac.RelType.COLLECTION), None
         )
         if collection_link is not None:
-            collection_href = cast(Dict[str, Any], collection_link).get("href")
+            collection_href = collection_link.get("href")
             if collection_href is not None:
                 if json_href is not None:
                     collection_href = make_absolute_href(collection_href, json_href)

pystac/stac_object.py

@@ -64,7 +64,7 @@ def add_link(self, link: Link) -> None:
         Args:
              link : The link to add.
         """
-        link.set_owner(cast(STACObject, self))
+        link.set_owner(self)
         self.links.append(link)
 
     def add_links(self, links: List[Link]) -> None:
@@ -179,18 +179,14 @@ def set_self_href(self, href: Optional[str]) -> None:
         """
         root_link = self.get_root_link()
         if root_link is not None and root_link.is_resolved():
-            cast(pystac.Catalog, root_link.target)._resolved_objects.remove(
-                cast(STACObject, self)
-            )
+            cast(pystac.Catalog, root_link.target)._resolved_objects.remove(self)
 
         self.remove_links(pystac.RelType.SELF)
         if href is not None:
             self.add_link(Link.self_href(href))
 
         if root_link is not None and root_link.is_resolved():
-            cast(pystac.Catalog, root_link.target)._resolved_objects.cache(
-                cast(STACObject, self)
-            )
+            cast(pystac.Catalog, root_link.target)._resolved_objects.cache(self)
 
     def get_root(self) -> Optional["Catalog_Type"]:
         """Get the :class:`~pystac.Catalog` or :class:`~pystac.Collection` to

pystac/summaries.py

@@ -13,7 +13,6 @@
     List,
     Optional,
     Union,
-    cast,
     TypeVar,
     Iterable,
     TYPE_CHECKING,
@@ -130,23 +129,23 @@ def _update_with_item(self, summaries: "Summaries", item: "Item_Type") -> None:
                     and isinstance(v, numbers.Number)
                     and not isinstance(v, bool)
                 ):
-                    rangesummary: Optional[RangeSummary] = summaries.get_range(k)
+                    rangesummary: Optional[RangeSummary[Any]] = summaries.get_range(k)
                     if rangesummary is None:
                         summaries.add(k, RangeSummary(v, v))
                     else:
                         rangesummary.update_with_value(v)
                 elif strategy == SummaryStrategy.ARRAY or (
                     strategy == SummaryStrategy.DEFAULT and isinstance(v, list)
                 ):
-                    listsummary: list = summaries.get_list(k) or []
+                    listsummary: List[Any] = summaries.get_list(k) or []
                     if not isinstance(v, list):
                         v = [v]
                     for element in v:
                         if element not in listsummary:
                             listsummary.append(element)
                     summaries.add(k, listsummary)
                 else:
-                    summary: list = summaries.get_list(k) or []
+                    summary: List[Any] = summaries.get_list(k) or []
                     if v not in summary:
                         summary.append(v)
                     summaries.add(k, summary)
@@ -202,9 +201,7 @@ def add(
             self.lists[prop_key] = summary
         elif isinstance(summary, dict):
             if "minimum" in summary:
-                self.ranges[prop_key] = RangeSummary[Any].from_dict(
-                    cast(Dict[str, Any], summary)
-                )
+                self.ranges[prop_key] = RangeSummary[Any].from_dict(summary)
             else:
                 self.schemas[prop_key] = summary
         elif isinstance(summary, RangeSummary):