Fix collection assets

Assets were being created with the href set to the entire asset
dictionary.

Author: gadomski

pystac/collection.py

@@ -715,7 +715,7 @@ def from_dict(
 
         if assets is not None:
             for asset_key, asset_dict in assets.items():
-                collection.add_asset(asset_key, Asset(asset_dict))
+                collection.add_asset(asset_key, Asset.from_dict(asset_dict))
 
         return collection
 

tests/data-files/collections/with-assets.json

@@ -0,0 +1,57 @@
+{
+    "type": "Collection",
+    "id": "area-1-1",
+    "stac_version": "1.0.0-rc.4",
+    "description": "test collection country-1",
+    "links": [
+        {
+            "rel": "root",
+            "href": "./multi-extent.json",
+            "type": "application/json"
+        },
+        {
+            "rel": "item",
+            "href": "./area-1-1-imagery/area-1-1-imagery.json",
+            "type": "application/json"
+        },
+        {
+            "rel": "item",
+            "href": "./area-1-1-labels/area-1-1-labels.json",
+            "type": "application/json"
+        },
+        {
+            "rel": "parent",
+            "href": "../catalog.json",
+            "type": "application/json"
+        }
+    ],
+    "stac_extensions": [],
+    "extent": {
+        "spatial": {
+            "bbox": [
+                [
+                    -2.5048828125,
+                    3.8916575492899987,
+                    -1.9610595703125,
+                    4.275202171119132
+                ]
+            ]
+        },
+        "temporal": {
+            "interval": [
+                [
+                    "2019-10-04T18:55:37Z",
+                    null
+                ]
+            ]
+        }
+    },
+    "license": "proprietary",
+    "assets": {
+        "thumbnail": {
+            "title": "thumbnail",
+            "href": "http://example.com/thumbnail.png",
+            "media_type": "image/png"
+        }
+    }
+}

tests/test_collection.py

@@ -175,6 +175,13 @@ def test_collection_with_href_caches_by_href(self) -> None:
         # cached only by HREF
         self.assertEqual(len(cache.id_keys_to_objects), 0)
 
+    def test_assets(self) -> None:
+        path = TestCases.get_path("data-files/collections/with-assets.json")
+        with open(path) as f:
+            data = json.load(f)
+        collection = pystac.read_dict(data)
+        collection.validate()
+
 
 class ExtentTest(unittest.TestCase):
     def test_spatial_allows_single_bbox(self) -> None: