feat: Treat unused ignores as an error

Author: l0b0

mypy.ini

@@ -6,3 +6,4 @@ no_implicit_optional = True
 show_error_codes = True
 warn_redundant_casts = True
 warn_return_any = True
+warn_unused_ignores = True

pystac/__init__.py

@@ -4,36 +4,36 @@
 
 # flake8: noqa
 from pystac.errors import (
-    STACError,  # type:ignore
-    STACTypeError,  # type:ignore
-    ExtensionAlreadyExistsError,  # type:ignore
-    ExtensionTypeError,  # type:ignore
-    RequiredPropertyMissing,  # type:ignore
-    STACValidationError,  #  type:ignore
+    STACError,
+    STACTypeError,
+    ExtensionAlreadyExistsError,
+    ExtensionTypeError,
+    RequiredPropertyMissing,
+    STACValidationError,
 )
 
 from typing import Any, Dict, Optional
 from pystac.version import (
     __version__,
-    get_stac_version,  # type:ignore
-    set_stac_version,  # type:ignore
+    get_stac_version,
+    set_stac_version,
 )
-from pystac.media_type import MediaType  # type:ignore
-from pystac.rel_type import RelType  # type: ignore
-from pystac.stac_io import StacIO  # type:ignore
-from pystac.stac_object import STACObject, STACObjectType  # type:ignore
-from pystac.link import Link, HIERARCHICAL_LINKS  # type:ignore
-from pystac.catalog import Catalog, CatalogType  # type:ignore
+from pystac.media_type import MediaType
+from pystac.rel_type import RelType
+from pystac.stac_io import StacIO
+from pystac.stac_object import STACObject, STACObjectType
+from pystac.link import Link, HIERARCHICAL_LINKS
+from pystac.catalog import Catalog, CatalogType
 from pystac.collection import (
-    Collection,  # type:ignore
-    Extent,  # type:ignore
-    SpatialExtent,  # type:ignore
-    TemporalExtent,  # type:ignore
-    Provider,  # type:ignore
-    Summaries,  # type:ignore
+    Collection,
+    Extent,
+    SpatialExtent,
+    TemporalExtent,
+    Provider,
+    Summaries,
 )
-from pystac.summaries import RangeSummary  # type:ignore
-from pystac.item import Item, Asset, CommonMetadata  # type:ignore
+from pystac.summaries import RangeSummary
+from pystac.item import Item, Asset, CommonMetadata
 
 import pystac.validation
 

pystac/serialization/__init__.py

@@ -3,7 +3,7 @@
 
 import pystac
 from pystac.serialization.identify import (
-    STACVersionRange,  # type:ignore
+    STACVersionRange,
     identify_stac_object,
     identify_stac_object_type,
 )

pystac/stac_io.py

@@ -23,7 +23,7 @@
 
 # Use orjson if available
 try:
-    import orjson  # type: ignore
+    import orjson
 except ImportError:
     orjson = None  # type: ignore[assignment]
 

pystac/stac_object.py

@@ -56,7 +56,7 @@ def validate(self) -> List[Any]:
         """
         import pystac.validation
 
-        return pystac.validation.validate(self)  # type:ignore
+        return pystac.validation.validate(self)
 
     def add_link(self, link: Link) -> None:
         """Add a link to this object's set of links.

pystac/utils.py

@@ -194,8 +194,14 @@ def extract_coords(coords: List[Union[List[float], List[List[Any]]]]) -> None:
         for x in coords:
             # This handles points
             if isinstance(x, float):
-                lats.append(coords[0])  # type:ignore
-                lons.append(coords[1])  # type:ignore
+                assert isinstance(
+                    coords[0], float
+                ), f"Type mismatch: {coords[0]} is not a float"
+                assert isinstance(
+                    coords[1], float
+                ), f"Type mismatch: {coords[1]} is not a float"
+                lats.append(coords[0])
+                lons.append(coords[1])
                 return
             if isinstance(x[0], list):
                 extract_coords(x)  # type:ignore

pystac/validation/__init__.py

@@ -162,7 +162,7 @@ class RegisteredValidator:
     def get_validator(cls) -> STACValidator:
         if cls._validator is None:
             try:
-                import jsonschema  # type:ignore
+                import jsonschema
             except ImportError:
                 raise Exception(
                     'Cannot validate with default validator because package "jsonschema" '

pystac/validation/stac_validator.py

@@ -157,9 +157,7 @@ def get_schema_from_uri(self, schema_uri: str) -> Tuple[Dict[str, Any], Any]:
 
     def _validate_from_uri(self, stac_dict: Dict[str, Any], schema_uri: str) -> None:
         schema, resolver = self.get_schema_from_uri(schema_uri)
-        jsonschema.validate(
-            instance=stac_dict, schema=schema, resolver=resolver
-        )  # type:ignore
+        jsonschema.validate(instance=stac_dict, schema=schema, resolver=resolver)
         for uri in resolver.store:
             if uri not in self.schema_cache:
                 self.schema_cache[uri] = resolver.store[uri]

tests/serialization/test_identify.py

@@ -60,7 +60,7 @@ def test_version_ordering(self) -> None:
         self.assertTrue(STACVersionID("0.9.0") <= "0.9.0")  # type:ignore
         self.assertTrue(
             STACVersionID("1.0.0-beta.1")  # type:ignore
-            <= STACVersionID("1.0.0-beta.2")  # type:ignore
+            <= STACVersionID("1.0.0-beta.2")
         )
         self.assertFalse(STACVersionID("1.0.0") < STACVersionID("1.0.0-beta.2"))
 

tests/utils/__init__.py

@@ -3,18 +3,18 @@
 from typing import Any, Dict, Type
 import unittest
 from tests.utils.test_cases import (
-    TestCases,  # type:ignore
-    ARBITRARY_GEOM,  # type:ignore
-    ARBITRARY_BBOX,  # type:ignore
-    ARBITRARY_EXTENT,  # type:ignore
+    TestCases,
+    ARBITRARY_GEOM,
+    ARBITRARY_BBOX,
+    ARBITRARY_EXTENT,
 )
 
 from copy import deepcopy
 from datetime import datetime
 from dateutil.parser import parse
 
 import pystac
-from tests.utils.stac_io_mock import MockStacIO  #  type:ignore
+from tests.utils.stac_io_mock import MockStacIO
 
 
 def assert_to_from_dict(