Skip to content

Commit 5f2296f

Browse files
committed
Improve coverage for scientific, version exts
1 parent b83338d commit 5f2296f

File tree

3 files changed

+24
-7
lines changed

3 files changed

+24
-7
lines changed

tests/extensions/test_datacube.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
1-
import json
21
import unittest
32
import pystac
43
from pystac.extensions.datacube import DatacubeExtension
54

6-
from tests.utils import TestCases, assert_to_from_dict
5+
from tests.utils import TestCases
76

87

98
class DatacubeTest(unittest.TestCase):
109
def setUp(self) -> None:
1110
self.maxDiff = None
12-
self.example_uri = TestCases.get_path(
13-
"data-files/datacube/item.json"
14-
)
15-
11+
self.example_uri = TestCases.get_path("data-files/datacube/item.json")
12+
1613
def test_validate_datacube(self) -> None:
1714
item = pystac.Item.from_file(self.example_uri)
1815
item.validate()
@@ -52,4 +49,4 @@ def test_asset_ext_add_to(self) -> None:
5249

5350
_ = DatacubeExtension.ext(asset, add_if_missing=True)
5451

55-
self.assertIn(DatacubeExtension.get_schema_uri(), item.stac_extensions)
52+
self.assertIn(DatacubeExtension.get_schema_uri(), item.stac_extensions)

tests/extensions/test_scientific.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,17 @@ def test_extension_not_implemented(self) -> None:
395395
with self.assertRaises(pystac.ExtensionNotImplemented):
396396
_ = ScientificExtension.ext(collection)
397397

398+
def test_ext_add_to(self) -> None:
399+
collection = pystac.Collection.from_file(self.example_collection_uri)
400+
collection.stac_extensions.remove(ScientificExtension.get_schema_uri())
401+
self.assertNotIn(
402+
ScientificExtension.get_schema_uri(), collection.stac_extensions
403+
)
404+
405+
_ = ScientificExtension.ext(collection, add_if_missing=True)
406+
407+
self.assertIn(ScientificExtension.get_schema_uri(), collection.stac_extensions)
408+
398409

399410
class SummariesScientificTest(unittest.TestCase):
400411
def setUp(self) -> None:

tests/extensions/test_version.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,15 @@ def test_extension_not_implemented(self) -> None:
452452
with self.assertRaises(pystac.ExtensionNotImplemented):
453453
_ = VersionExtension.ext(collection)
454454

455+
def test_ext_add_to(self) -> None:
456+
collection = pystac.Collection.from_file(self.example_collection_uri)
457+
collection.stac_extensions.remove(VersionExtension.get_schema_uri())
458+
self.assertNotIn(VersionExtension.get_schema_uri(), collection.stac_extensions)
459+
460+
_ = VersionExtension.ext(collection, add_if_missing=True)
461+
462+
self.assertIn(VersionExtension.get_schema_uri(), collection.stac_extensions)
463+
455464

456465
if __name__ == "__main__":
457466
unittest.main()

0 commit comments

Comments
 (0)