Merge pull request #309 from stac-utils/feature/rde/1.0-refactors

Refactors architecture to better enable STAC 1.0 extension changes

Author: lossyrob

.flake8

@@ -1,14 +1,3 @@
 [flake8]
-max-line-length = 100
-
-## IGNORES
-
-# E126: yapf conflicts with "continuation line over-indented for hanging indent"
-
-# E127: flake8 reporting incorrect continuation line indent errors
-# on multi-line and multi-level indents
-
-# W503: flake8 reports this as incorrect, and scripts/format_code
-# changes code to it, so let format_code win.
-
-ignore = E126,E127,W503
+max-line-length = 88
+extend-ignore = E203, W503, E731, E722

CHANGELOG.md

@@ -4,12 +4,26 @@
 
 ### Added
 
+- Added type annotations across the library ([#309](https://github.com/stac-utils/pystac/pull/309))
+- Added assets to collections ([#309](https://github.com/stac-utils/pystac/pull/309))
+- `item_assets` extension ([#309](https://github.com/stac-utils/pystac/pull/309))
+- `datacube` extension ([#309](https://github.com/stac-utils/pystac/pull/309))
+- Added specific errors: `ExtensionAlreadyExistsError`, `ExtensionTypeError`, and `RequiredPropertyMissing`; moved custom exceptions to `pystac.errors` ([#309](https://github.com/stac-utils/pystac/pull/309))
+
 ### Fixed
 
 ### Changed
 
+- API change: The extension API changed significantly. See ([#309](https://github.com/stac-utils/pystac/pull/309)) for more details.
+- API change: Refactored the global STAC_IO object to an instance-specific `StacIO` implementation. STAC_IO is deprecated and will be removed next release. ([#309](https://github.com/stac-utils/pystac/pull/309))
+- Asset.get_absolute_href returns None if no absolute href can be inferred (previously the relative href that was passed in was returned) ([#309](https://github.com/stac-utils/pystac/pull/309))
+
 ### Removed
 
+- Removed `properties` from Collections ([#309](https://github.com/stac-utils/pystac/pull/309))
+- Removed `LinkMixin`, and implemented those methods on `STACObject` directly. STACObject was the only class using LinkMixin and this should not effect users ([#309](https://github.com/stac-utils/pystac/pull/309)
+- Removed `single-file-stac` extension; this extension is being removed in favor of ItemCollection usage ([#309](https://github.com/stac-utils/pystac/pull/309)
+
 ## [v0.5.6]
 
 ### Added

README.md

@@ -114,6 +114,14 @@ To build and develop the documentation locally, make sure sphinx is available (w
 > make livehtml
 ```
 
+> Note: You will see some warnings along the lines of 
+> ```
+> WARNING: duplicate object description of pystac.Collection.id, 
+> other instance in api, use :noindex: for one of them
+> ``` 
+> for some of the
+> classes. This is expected due to [sphinx-doc/sphinx#8664](https://github.com/sphinx-doc/sphinx/issues/8664).
+
 Use 'make' without arguments to see a list of available commands.
 
 __Note__: `nbsphinx` requires that a local `pystac` is installed; use `pip install -e .`.

docs/api.rst

@@ -127,13 +127,6 @@ Link
    :members:
    :undoc-members:
 
-LinkType
-~~~~~~~~
-
-.. autoclass:: pystac.LinkType
-   :members:
-   :undoc-members:
-
 MediaType
 ~~~~~~~~~
 
@@ -149,7 +142,7 @@ STAC_IO
 
 STAC_IO is the utility mechanism that PySTAC uses for reading and writing. Users of PySTAC can hook into PySTAC by overriding members to utilize their own IO methods.
 
-.. autoclass:: pystac.STAC_IO
+.. autoclass:: pystac.stac_io.STAC_IO
    :members:
    :undoc-members:
 
@@ -193,17 +186,20 @@ ExtensionError
 Extensions
 ----------
 
-.. autoclass:: pystac.extensions.Extensions
-   :members:
-   :undoc-members:
+**TEMPORARILY REMOVED**
+.. .. autoclass:: pystac.extensions.Extensions
+..    :members:
+..    :undoc-members:
 
 ExtensionIndex
 ~~~~~~~~~~~~~~
 
-An ExtensionIndex is accessed through the :attr:`STACObject.ext <pystac.STACObject.ext>` property and is the primary way to access information and functionality around STAC extensions.
+**TEMPORARILY REMOVED**
+
+.. An ExtensionIndex is accessed through the :attr:`STACObject.ext <pystac.STACObject.ext>` property and is the primary way to access information and functionality around STAC extensions.
 
-.. autoclass:: pystac.stac_object.ExtensionIndex
-   :members: __getitem__, __getattr__, enable, implements
+.. .. autoclass:: pystac.stac_object.ExtensionIndex
+..    :members: __getitem__, __getattr__, enable, implements
 
 
 EO Extension
@@ -214,17 +210,21 @@ These classes are representations of the `EO Extension Spec <https://github.com/
 EOItemExt
 ~~~~~~~~~
 
-.. autoclass:: pystac.extensions.eo.EOItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.eo.EOItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 Band
 ~~~~
 
-.. autoclass:: pystac.extensions.eo.Band
-   :members:
-   :undoc-members:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.eo.Band
+..    :members:
+..    :undoc-members:
 
 
 Label Extension
@@ -235,10 +235,12 @@ These classes are representations of the `Label Extension Spec <https://github.c
 LabelItemExt
 ~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.label.LabelItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.label.LabelItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 LabelType
 ~~~~~~~~~
@@ -283,10 +285,12 @@ Implements the `Point Cloud Extension <https://github.com/radiantearth/stac-spec
 PointcloudItemExt
 ~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.pointcloud.PointcloudItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.pointcloud.PointcloudItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 Projection Extension
 --------------------
@@ -296,10 +300,12 @@ Implements the `Projection Extension <https://github.com/radiantearth/stac-spec/
 ProjectionItemExt
 ~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.projection.ProjectionItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.projection.ProjectionItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 Timestamps Extension
 --------------------
@@ -309,10 +315,12 @@ Implements the `Timestamps Extension <https://github.com/radiantearth/stac-spec/
 TimestampsItemExt
 ~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.timestamps.TimestampsItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.timestamps.TimestampsItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 SAR Extension
 -------------
@@ -322,10 +330,12 @@ Implements the `SAR Extension <https://github.com/radiantearth/stac-spec/tree/v1
 SarItemExt
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.sar.SarItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.sar.SarItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 SAT Extension
 -------------
@@ -335,25 +345,31 @@ Implements the `SAT Extension <https://github.com/radiantearth/stac-spec/tree/v1
 SatItemExt
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.sar.SatItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.sar.SatItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 Single File STAC Extension
 --------------------------
 
 These classes are representations of the `Single File STAC Extension <https://github.com/radiantearth/stac-spec/tree/v1.0.0-beta.2/extensions/single-file-stac>`_.
 
-.. automodule:: pystac.extensions.single_file_stac
-   :members: create_single_file_stac
+**TEMPORARILY REMOVED**
+
+.. .. automodule:: pystac.extensions.single_file_stac
+..    :members: create_single_file_stac
 
 SingleFileSTACCatalogExt
 ~~~~~~~~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.single_file_stac.SingleFileSTACCatalogExt
-   :members:
-   :undoc-members:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.single_file_stac.SingleFileSTACCatalogExt
+..    :members:
+..    :undoc-members:
 
 Version Extension
 -----------------
@@ -363,18 +379,22 @@ Implements the `Version Extension <https://github.com/radiantearth/stac-spec/tre
 VersionCollectionExt
 ~~~~~~~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.version.VersionCollectionExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.version.VersionCollectionExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 VersionItemExt
 ~~~~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.version.VersionItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.version.VersionItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 View Geometry Extension
 -----------------------
@@ -384,10 +404,12 @@ Implements the `View Geometry Extension <https://github.com/radiantearth/stac-sp
 ViewItemExt
 ~~~~~~~~~~~
 
-.. autoclass:: pystac.extensions.view.ViewItemExt
-   :members:
-   :undoc-members:
-   :show-inheritance:
+**TEMPORARILY REMOVED**
+
+.. .. autoclass:: pystac.extensions.view.ViewItemExt
+..    :members:
+..    :undoc-members:
+..    :show-inheritance:
 
 Serialization
 -------------
@@ -401,17 +423,17 @@ Identification
 .. automodule:: pystac.serialization
    :members: identify_stac_object
 
-.. autoclass:: pystac.serialization.STACJSONDescription
-   :members:
-   :undoc-members:
+.. .. autoclass:: pystac.serialization.STACJSONDescription
+..    :members:
+..    :undoc-members:
 
 .. autoclass:: pystac.serialization.STACVersionRange
    :members:
    :undoc-members:
 
-.. autoclass:: pystac.serialization.STACVersionID
-   :members:
-   :undoc-members:
+.. .. autoclass:: pystac.serialization.STACVersionID
+..    :members:
+..    :undoc-members:
 
 
 Migration
@@ -456,8 +478,8 @@ schema URIs. A default implementation is included that uses known locations; how
 can provide their own schema URI maps in a :class:`~pystac.validation.JsonSchemaSTACValidator`
 to modify the URIs used.
 
-.. autoclass:: pystac.validation.SchemaUriMap
-   :members:
+.. .. autoclass:: pystac.validation.SchemaUriMap
+..    :members:
 
 .. autoclass:: pystac.validation.schema_uri_map.DefaultSchemaUriMap
    :members:

docs/concepts.rst

@@ -159,7 +159,7 @@ are relative to the linking object's file location. For example, if a catalog at
 then that link should resolve to the absolute path ``/some/location/item-id/item-id.json``.
 
 Links are set as absolute or relative HREFs at save time, as determine by the root catalog's catalog_type
-:attribute:`~pystac.Catalog.catalog_type`. This means that, even if the stored HREF of the link is absolute,
+:attr:`~pystac.Catalog.catalog_type`. This means that, even if the stored HREF of the link is absolute,
 if the root ``catalog_type=CatalogType.RELATIVE_PUBLISHED`` or ``catalog_type=CatalogType.SELF_CONTAINED``
 and subsequent serializing of the any links in the catalog will produce a relative link,
 based on the self link of the parent object.
@@ -396,7 +396,7 @@ Item Asset properties
 
 Properties that apply to Items can be found in two places: the Item's properties or in any of an Item's Assets. If the property is on an Asset, it applies only that specific asset. For example, gsd defined for an Item represents the best Ground Sample Distance (resolution) for the data within the Item. However, some assets may be lower resolution and thus have a higher gsd. In that case, the `gsd` can be found on the Asset.
 
-See the STAC documentation on `Additional Fields for Assets <https://github.com/radiantearth/stac-spec/blob/v1.0.0-beta.2/item-spec/item-spec.md#additional-fields-for-assets>`_ and the relevant `Best Practices <https://github.com/radiantearth/stac-spec/blob/v1.0.0-beta.2/best-practices.md#common-use-cases-of-additional-fields-for-assets>`_ for more information.
+See the STAC documentation on `Additional Fields for Assets <https://github.com/radiantearth/stac-spec/blob/v1.0.0-beta.2/item-spec/item-spec.md#additional-fields-for-assets>`_ and the relevant `Best Practices <https://github.com/radiantearth/stac-spec/blob/v1.0.0-beta.2/best-practices.md#common-use-cases-of-additional-fields-for-assets>`__ for more information.
 
 The implementation of this feature in PySTAC uses the method described here and is consistent across Item and ItemExtensions. The bare property names represent values for the Item only, but for each property where it is possible to set on both the Item or the Asset there is a ``get_`` and ``set_`` methods that optionally take an Asset. For the ``get_`` methods, if the property is found on the Asset, the Asset's value is used; otherwise the Item's value will be used. For the ``set_`` method, if an Asset is passed in the value will be applied to the Asset and not the Item.
 

mypy.ini

@@ -0,0 +1,3 @@
+[mypy]
+ignore_missing_imports = True
+disallow_untyped_defs = True