include object links from extensions in list of hierarchical link rel types

Author: matthewhanson

pystac/link.py

@@ -1,5 +1,6 @@
 from copy import copy
 
+import pystac
 from pystac import STACError
 from pystac.stac_io import STAC_IO
 from pystac.utils import (make_absolute_href, make_relative_href, is_absolute_href)
@@ -81,12 +82,14 @@ def get_href(self):
         else:
             href = self.target
 
-        # if a hierarchical link with an owner and root, and relative catalog
-        if self.rel in HIERARCHICAL_LINKS and self.owner is not None:
-            root = self.owner.get_root()
-            if root is not None and root.catalog_type in ['RELATIVE_PUBLISHED', 'SELF_CONTAINED']:
-                if href and is_absolute_href(href):
-                    href = make_relative_href(href, self.owner.get_self_href())
+        if href and self.owner is not None:
+            rel_links = HIERARCHICAL_LINKS + pystac.STAC_EXTENSIONS.get_extended_object_links(self.owner)
+            # if a hierarchical link with an owner and root, and relative catalog
+            if self.rel in rel_links:
+                root = self.owner.get_root()
+                if root is not None and root.catalog_type in ['RELATIVE_PUBLISHED', 'SELF_CONTAINED']:
+                    if href and is_absolute_href(href):
+                        href = make_relative_href(href, self.owner.get_self_href())
 
         return href
 

tests/test_writing.py

@@ -1,6 +1,7 @@
 import unittest
 from tempfile import TemporaryDirectory
 
+import pystac
 from pystac import (STAC_IO, STACObject, Collection, CatalogType, HIERARCHICAL_LINKS)
 from pystac.serialization import (STACObjectType)
 from pystac.utils import is_absolute_href, make_absolute_href, make_relative_href
@@ -46,9 +47,10 @@ def validate_asset_href_type(item, item_href, link_type):
         def validate_item_link_type(href, link_type, should_include_self):
             item_dict = STAC_IO.read_json(href)
             item = STACObject.from_file(href)
+            rel_links = HIERARCHICAL_LINKS + pystac.STAC_EXTENSIONS.get_extended_object_links(item)
             for link in item.get_links():
                 if not link.rel == 'self':
-                    if link_type == 'RELATIVE' and link.rel in HIERARCHICAL_LINKS:
+                    if link_type == 'RELATIVE' and link.rel in rel_links:
                         self.assertFalse(is_absolute_href(link.get_href()))
                     else:
                         self.assertTrue(is_absolute_href(link.get_href()))