Merge pull request #273 from moradology/feature/rm-extra-deepcopies

Remove unnecessary deepcopies

Author: lossyrob

CHANGELOG.md

@@ -6,6 +6,8 @@
 
 - Fix handling of optional properties when using apply on view extension ([#259](https://github.com/stac-utils/pystac/pull/259))
 - Fixed issue with setting None into projection extension fields that are not required breaking validation ([#269](https://github.com/stac-utils/pystac/pull/269))
+- Remove unnecessary `deepcopy` calls in `to_dict` methods to avoid costly overhead ([#273](https://github.com/stac-utils/pystac/pull/273))
+
 
 ### Changed
 

pystac/catalog.py

@@ -381,7 +381,7 @@ def to_dict(self, include_self_link=True):
         if self.title is not None:
             d['title'] = self.title
 
-        return deepcopy(d)
+        return d
 
     def clone(self):
         clone = Catalog(id=self.id,

pystac/collection.py

@@ -107,7 +107,7 @@ def to_dict(self, include_self_link=True):
         if self.summaries is not None:
             d['summaries'] = self.summaries
 
-        return deepcopy(d)
+        return d
 
     def clone(self):
         clone = Collection(id=self.id,
@@ -213,7 +213,7 @@ def to_dict(self):
         """
         d = {'spatial': self.spatial.to_dict(), 'temporal': self.temporal.to_dict()}
 
-        return deepcopy(d)
+        return d
 
     def clone(self):
         """Clones this object.
@@ -315,7 +315,7 @@ def to_dict(self):
             dict: A serializion of the SpatialExtent that can be written out as JSON.
         """
         d = {'bbox': self.bboxes}
-        return deepcopy(d)
+        return d
 
     def clone(self):
         """Clones this object.
@@ -418,7 +418,7 @@ def to_dict(self):
             encoded_intervals.append([start, end])
 
         d = {'interval': encoded_intervals}
-        return deepcopy(d)
+        return d
 
     def clone(self):
         """Clones this object.
@@ -505,7 +505,7 @@ def to_dict(self):
         if self.url is not None:
             d['url'] = self.url
 
-        return deepcopy(d)
+        return d
 
     @staticmethod
     def from_dict(d):

pystac/item.py

@@ -297,7 +297,7 @@ def to_dict(self, include_self_link=True):
         for key in self.extra_fields:
             d[key] = self.extra_fields[key]
 
-        return deepcopy(d)
+        return d
 
     def clone(self):
         clone = Item(id=self.id,
@@ -475,7 +475,7 @@ def to_dict(self):
         if self.roles is not None:
             d['roles'] = self.roles
 
-        return deepcopy(d)
+        return d
 
     def clone(self):
         """Clones this asset.

pystac/link.py

@@ -1,4 +1,4 @@
-from copy import (copy, deepcopy)
+from copy import copy
 from enum import Enum
 
 from pystac import STACError
@@ -211,7 +211,7 @@ def to_dict(self):
             for k, v in self.properties.items():
                 d[k] = v
 
-        return deepcopy(d)
+        return d
 
     def clone(self):
         """Clones this link.