Simplify dirname logic for URLs

duckontheweb · duckontheweb · commit 3467b4c97e84 · 2021-06-04T11:16:02.000-04:00
diff --git a/pystac/utils.py b/pystac/utils.py
@@ -74,7 +74,7 @@ def _make_relative_href_url(
 
     # If the start path is not a directory, get the parent directory
     start_dir = (
-        parsed_start.path if start_is_dir else parsed_start.path.rsplit("/", 1)[0]
+        parsed_start.path if start_is_dir else _pathlib.dirname(parsed_start.path)
     )
 
     # Strip the leading slashes from both paths

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ def _make_relative_href_url(`
`74`	`74`
`75`	`75`	`# If the start path is not a directory, get the parent directory`
`76`	`76`	`start_dir = (`
`77`		`- parsed_start.path if start_is_dir else parsed_start.path.rsplit("/", 1)[0]`
	`77`	`+ parsed_start.path if start_is_dir else _pathlib.dirname(parsed_start.path)`
`78`	`78`	`)`
`79`	`79`
`80`	`80`	`# Strip the leading slashes from both paths`