Asset.get_absoulte_href returns None if no abs href possible

Author: lossyrob

pystac/asset.py

@@ -79,19 +79,20 @@ def set_owner(self, obj: Union["Collection_Type", "Item_Type"]) -> None:
     def get_absolute_href(self) -> Optional[str]:
         """Gets the absolute href for this asset, if possible.
 
-        If this Asset has no associated Item, this will return whatever the
-        href is (as it cannot determine the absolute path, if the asset
-        href is relative).
+        If this Asset has no associated Item, and the asset HREF is a relative path,
+            this method will return None.
 
         Returns:
-            str: The absolute HREF of this asset, or a relative HREF if an absolute HREF
-            cannot be determined.
+            str: The absolute HREF of this asset, or None if an absolute HREF could not
+                be determined.
         """
-        if not is_absolute_href(self.href):
+        if is_absolute_href(self.href):
+            return self.href
+        else:
             if self.owner is not None:
                 return make_absolute_href(self.href, self.owner.get_self_href())
-
-        return self.href
+            else:
+                return None
 
     def to_dict(self) -> Dict[str, Any]:
         """Generate a dictionary representing the JSON of this Asset.

pystac/utils.py

@@ -100,8 +100,7 @@ def make_absolute_href(
 
     Returns:
         str: The absolute HREF. If the source_href is already an absolute href,
-        then it will be returned unchanged. If the source_href it None, it will
-        return None.
+        then it will be returned unchanged.
     """
     if start_href is None:
         start_href = os.getcwd()