linting updates

Author: matthewhanson

pystac/catalog.py

@@ -492,7 +492,7 @@ def fn():
             setter_funcs.append(fn)
 
             return setter_funcs
-        
+
         # Collect functions that will actually mutate the objects.
         # Delay mutation as setting hrefs while walking the catalog
         # can result in bad links.
@@ -598,11 +598,11 @@ def save(self, catalog_type=None):
 
         include_self_link = False
         # include a self link if this is the root catalog or if ABSOLUTE_PUBLISHED catalog
-        if ((self.get_self_href() == self.get_root_link().get_absolute_href() 
-            and root.catalog_type != CatalogType.SELF_CONTAINED) or
-            root.catalog_type == CatalogType.ABSOLUTE_PUBLISHED):
+        if ((self.get_self_href() == self.get_root_link().get_absolute_href()
+                and root.catalog_type != CatalogType.SELF_CONTAINED)
+                or root.catalog_type == CatalogType.ABSOLUTE_PUBLISHED):
             include_self_link = True
-        
+
         self.save_object(include_self_link=include_self_link)
 
         self.catalog_type = catalog_type

pystac/link.py

@@ -1,5 +1,4 @@
 from copy import (copy, deepcopy)
-from enum import Enum
 
 from pystac import STACError
 from pystac.stac_io import STAC_IO
@@ -77,9 +76,9 @@ def get_href(self):
         """Gets the HREF for this link.
 
         Returns:
-            str: Returns this link's HREF. If there is an owner of the link and 
+            str: Returns this link's HREF. If there is an owner of the link and
             the root catalog (if there is one) is of type RELATIVE_PUBLISHED,
-            then the HREF returned will be relative. 
+            then the HREF returned will be relative.
             In all other cases, this method will return an absolute HREF.
         """
         href = None

tests/test_catalog.py

@@ -6,7 +6,8 @@
 from collections import defaultdict
 
 import pystac
-from pystac import (Catalog, Collection, CatalogType, Item, Asset, MediaType, Extensions, HIERARCHICAL_LINKS)
+from pystac import (Catalog, Collection, CatalogType,
+                    Item, Asset, MediaType, Extensions, HIERARCHICAL_LINKS)
 from pystac.extensions.label import LabelClasses
 from pystac.validation import STACValidationError
 from pystac.utils import is_absolute_href
@@ -656,8 +657,6 @@ def check_all_relative(cat):
                 for item in items:
                     for link in item.links:
                         if link.rel in HIERARCHICAL_LINKS:
-                            if is_absolute_href(link.get_href()):
-                                import pdb; pdb.set_trace()
                             self.assertFalse(is_absolute_href(link.get_href()))
 
         def check_all_absolute(cat):

tests/test_writing.py

@@ -30,7 +30,7 @@ def validate_file(self, path, object_type):
         d = STAC_IO.read_json(path)
         return validate_dict(d, object_type)
 
-    def validate_link_types(self, root_href, catalog_type):           
+    def validate_link_types(self, root_href, catalog_type):
 
         def validate_asset_href_type(item, item_href, link_type):
             for asset in item.assets.values():