-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Description
Issue from the comment:
a) here, you disallow everything greater than maxRound, which is 6 or 12 depending on role: https://github.com/ssvlabs/ssv/blob/90b226a61bf6fe655910edc61ce48058d6bb654f/message/validation/consensus_validation.go#L150-L155
b) here, you allow everything smaller than CutoffRound, which is 12: https://github.com/ssvlabs/ssv/blob/90b226a61bf6fe655910edc61ce48058d6bb654f/protocol/v2/qbft/instance/instance.go#L257-L260
It seems we have a mismatched check with message validation (<= vs. <), and the CutoffRound is always 12 while it should be 6 or 12 depending on the role.
We should analyze back what comparison and values should be used and enforce consistency with the message validation module.
Metadata
Metadata
Assignees
Labels
No labels