Skip to content

deliver() on a wrong DID does not raise exceptions #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArturU043 opened this issue Apr 30, 2025 · 1 comment
Open

deliver() on a wrong DID does not raise exceptions #585

ArturU043 opened this issue Apr 30, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ArturU043
Copy link
Contributor

Bug when inputing a Rucio DID with a typo.

The deliver call does not raise any errors, and it is not caught in a try Except.
Instead it returns a dictionary with the correct key (sample name) but with empty values.

A raise should be done on deliver to avoid this and warn the user about an error in the backend.


Example code, on version 3.1.0:

from servicex import deliver, query, dataset

query = query.UprootRaw(
    [
        {
            "treename": "reco",
            "filter_name": [
                "mu_phi",
                "mu_eta",
            ],
        }
    ]
)
spec = {
    "Sample": [
        {
            "Name": "uprootrawquery1",
            "Dataset": dataset.Rucio("user.mtost:NONEXISTING"),
            "NFiles": 1,
            "Query": query,
        },
    ],
}

print(f"Files: {deliver(spec)}")

Output:

uprootrawquery1: Transform ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0/0 --:--
                  Download ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0/0 --:--
Files: {'uprootrawquery1': []}
@ArturU043 ArturU043 added the bug Something isn't working label Apr 30, 2025
@MattShirley MattShirley self-assigned this Apr 30, 2025
@ponyisi
Copy link
Collaborator

ponyisi commented Apr 30, 2025

Connected to ssl-hep/ServiceX#927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants