Skip to content

Commit ccfe38c

Browse files
committed
Merge branch 'remove-s3-bucket-polling' of https://github.com/ssl-hep/ServiceX_frontend into remove-s3-bucket-polling
2 parents b80d72d + 85b5346 commit ccfe38c

File tree

3 files changed

+30
-24
lines changed

3 files changed

+30
-24
lines changed

servicex/query_core.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,11 @@ def transform_complete(task: Task):
344344

345345
download_files_task = loop.create_task(
346346
self.download_files(
347-
signed_urls_only, expandable_progress, download_progress, cached_record, begin_at
347+
signed_urls_only,
348+
expandable_progress,
349+
download_progress,
350+
cached_record,
351+
begin_at,
348352
)
349353
)
350354

@@ -564,8 +568,7 @@ async def get_signed_url(
564568
if self.current_status.files_completed > len(files_seen):
565569
new_begin_at = datetime.datetime.now(tz=datetime.timezone.utc)
566570
files = await self.servicex.get_transformation_results(
567-
self.current_status.request_id,
568-
begin_at
571+
self.current_status.request_id, begin_at
569572
)
570573
begin_at = new_begin_at
571574

servicex/servicex_adapter.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,9 @@ async def delete_transform(self, transform_id=None):
229229
f"Failed to delete transform {transform_id} - {msg}"
230230
)
231231

232-
async def get_transformation_results(self, request_id: str, begin_at: datetime.datetime):
232+
async def get_transformation_results(
233+
self, request_id: str, begin_at: datetime.datetime
234+
):
233235
headers = await self._get_authorization()
234236
url = self.url + f"/servicex/transformation/{request_id}/results"
235237

tests/test_servicex_dataset.py

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -208,13 +208,15 @@ async def test_submit(mocker):
208208
servicex.submit_transform = AsyncMock()
209209
servicex.submit_transform.return_value = {"request_id": '123-456-789"'}
210210

211-
servicex.get_transformation_results = AsyncMock(side_effect=[
212-
[{"file-path": file1.filename}],
213-
[
214-
{"file-path": file1.filename},
215-
{"file-path": file2.filename},
216-
],
217-
])
211+
servicex.get_transformation_results = AsyncMock(
212+
side_effect=[
213+
[{"file-path": file1.filename}],
214+
[
215+
{"file-path": file1.filename},
216+
{"file-path": file2.filename},
217+
],
218+
]
219+
)
218220

219221
servicex.get_transform_status = AsyncMock()
220222
servicex.get_transform_status.side_effect = [
@@ -255,17 +257,18 @@ async def test_submit(mocker):
255257
mock_cache.cache_transform.assert_called_once()
256258

257259

258-
259260
@pytest.mark.asyncio
260261
async def test_submit_partial_success(mocker):
261262
servicex = AsyncMock()
262263
servicex.submit_transform = AsyncMock()
263264
servicex.submit_transform.return_value = {"request_id": '123-456-789"'}
264265

265-
servicex.get_transformation_results = AsyncMock(side_effect=[
266-
[{"file-path": file1.filename}],
267-
[{"file-path": file1.filename}],
268-
])
266+
servicex.get_transformation_results = AsyncMock(
267+
side_effect=[
268+
[{"file-path": file1.filename}],
269+
[{"file-path": file1.filename}],
270+
]
271+
)
269272

270273
servicex.get_transform_status = AsyncMock()
271274
servicex.get_transform_status.side_effect = [
@@ -311,10 +314,9 @@ async def test_use_of_cache(mocker):
311314
servicex = AsyncMock()
312315
servicex.submit_transform = AsyncMock()
313316
servicex.submit_transform.return_value = {"request_id": '123-456-789"'}
314-
servicex.get_transformation_results = AsyncMock(return_value=[
315-
{"file-path": file1.filename},
316-
{"file-path": file2.filename}
317-
])
317+
servicex.get_transformation_results = AsyncMock(
318+
return_value=[{"file-path": file1.filename}, {"file-path": file2.filename}]
319+
)
318320
servicex.get_transform_status = AsyncMock()
319321
servicex.get_transform_status.side_effect = [
320322
transform_status1,
@@ -616,10 +618,9 @@ async def test_use_of_ignore_cache(mocker, servicex):
616618
transform_status3,
617619
]
618620
)
619-
servicex.get_transformation_results = AsyncMock(return_value=[
620-
{"file-path": file1.filename},
621-
{"file-path": file2.filename}
622-
])
621+
servicex.get_transformation_results = AsyncMock(
622+
return_value=[{"file-path": file1.filename}, {"file-path": file2.filename}]
623+
)
623624
# Prepare Minio
624625
mock_minio = AsyncMock()
625626
mock_minio.get_signed_url = AsyncMock(side_effect=["http://file1", "http://file2"])

0 commit comments

Comments
 (0)