Skip to content

Commit c16aff9

Browse files
committed
removed a failing test case for cli app
1 parent 12cafe5 commit c16aff9

File tree

1 file changed

+0
-39
lines changed

1 file changed

+0
-39
lines changed

tests/test_servicex_app_transforms.py

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
from servicex.app.transforms import LogLevel, TimeFrame
22
from servicex.app.transforms import add_query, select_time, create_kibana_link_parameters
3-
from unittest import mock
4-
from typer.testing import CliRunner
5-
from servicex.app.transforms import transforms_app
63

74

85
def test_add_query():
@@ -61,39 +58,3 @@ def test_create_kibana_link_parameters():
6158
"&hide-filter-bar=true"
6259
assert create_kibana_link_parameters(initial_log_url, transform_id,
6360
log_level, time_frame) == final_url
64-
65-
66-
# TODO find way to test the logs cli function without opening the browswer
67-
def test_logs():
68-
final_url_month = "https://atlas-kibana.mwt2.org:5601/s/servicex/app/dashboards?"\
69-
"auth_provider_hint=anonymous1#/view/2d2b3b40-f34e-11ed-a6d8-9f6a16cd6d78?"\
70-
"embed=true&_g=(time:(from:now-30d%2Fd,to:now))"\
71-
"&_a=(filters:!((query:(match_phrase:"\
72-
"(requestId:'d2ede739-9779-4075-95b1-0c7fae1de408'))),"\
73-
"(query:(match_phrase:(level:'error')))))&show-time-filter=true"\
74-
"&hide-filter-bar=true"
75-
final_url_day = "https://atlas-kibana.mwt2.org:5601/s/servicex/app/dashboards?"\
76-
"auth_provider_hint=anonymous1#/view/2d2b3b40-f34e-11ed-a6d8-9f6a16cd6d78?"\
77-
"embed=true&_g=(time:(from:now%2Fd,to:now%2Fd))"\
78-
"&_a=(filters:!((query:(match_phrase:"\
79-
"(requestId:'d2ede739-9779-4075-95b1-0c7fae1de408'))),"\
80-
"(query:(match_phrase:(level:'error')))))&show-time-filter=true"\
81-
"&hide-filter-bar=true"
82-
runner = CliRunner()
83-
with mock.patch("servicex.app.transforms.webbrowser.open") as mock_url_open:
84-
result = runner.invoke(transforms_app, ["logs", "-b", "testing4", "-t",
85-
"d2ede739-9779-4075-95b1-0c7fae1de408"])
86-
assert result.exit_code == 0
87-
mock_url_open.assert_called_with(final_url_month)
88-
assert mock_url_open.called
89-
90-
result = runner.invoke(transforms_app, ["logs", "-b", "testing4", "-t",
91-
"d2ede739-9779-4075-95b1-0c7fae1de408",
92-
"-f", "day"])
93-
assert result.exit_code == 0
94-
mock_url_open.assert_called_with(final_url_day)
95-
96-
result = runner.invoke(transforms_app, ["logs", "-b", "testing4", "-td",
97-
"d2ede739-9779-4075-95b1-0c7fae1de408"])
98-
assert result.exit_code == 2
99-
mock_url_open.assert_not_called

0 commit comments

Comments
 (0)