Skip to content

Commit 7e1621d

Browse files
committed
Fix tests
1 parent bbebd72 commit 7e1621d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/app/test_datasets.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
2323
import json
2424
from datetime import datetime
25-
from unittest.mock import patch, AsyncMock
25+
from unittest.mock import patch, MagicMock
2626

2727
import pytest
2828

@@ -66,7 +66,7 @@ def dataset():
6666

6767
def test_datasets_list(script_runner, dataset):
6868
with patch("servicex.app.datasets.ServiceXClient") as mock_servicex:
69-
mock_get_datasets = AsyncMock(return_value=[dataset])
69+
mock_get_datasets = MagicMock(return_value=[dataset])
7070
mock_servicex.return_value.get_datasets = mock_get_datasets
7171

7272
result = script_runner.run(
@@ -106,7 +106,7 @@ def test_datasets_list(script_runner, dataset):
106106

107107
def test_dataset_get(script_runner, dataset):
108108
with patch("servicex.app.datasets.ServiceXClient") as mock_servicex:
109-
mock_get_dataset = AsyncMock(return_value=dataset)
109+
mock_get_dataset = MagicMock(return_value=dataset)
110110
mock_servicex.return_value.get_dataset = mock_get_dataset
111111

112112
result = script_runner.run(
@@ -123,7 +123,7 @@ def test_dataset_get(script_runner, dataset):
123123

124124
def test_dataset_delete(script_runner):
125125
with patch("servicex.app.datasets.ServiceXClient") as mock_servicex:
126-
mock_delete_dataset = AsyncMock(return_value=True)
126+
mock_delete_dataset = MagicMock(return_value=True)
127127
mock_servicex.return_value.delete_dataset = mock_delete_dataset
128128

129129
result = script_runner.run(
@@ -133,7 +133,7 @@ def test_dataset_delete(script_runner):
133133
assert result.stdout == "Dataset 42 deleted\n"
134134
mock_delete_dataset.assert_called_once_with(42)
135135

136-
mock_delete_dataset_not_found = AsyncMock(return_value=False)
136+
mock_delete_dataset_not_found = MagicMock(return_value=False)
137137
mock_servicex.return_value.delete_dataset = mock_delete_dataset_not_found
138138
result = script_runner.run(
139139
["servicex", "datasets", "delete", "-c", "tests/example_config.yaml", "42"]

0 commit comments

Comments
 (0)