Refactor uproot-raw to chunk the processing #1059
Merged
+118
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ponyisi
requested review from
Copilot,
gordonwatts,
MattShirley,
BenGalewsky and
kyungeonchoi
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the uproot-raw processing to chunk transformation outputs, reducing memory usage under Kubernetes limits.
- Updated test expectations to reflect the new processing output.
- Introduced timing wrappers and incremental processing in the transformation and query translation code.
- Modified the query translation to yield results on the fly instead of collecting them in dictionaries.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| code_generator_raw_uproot/tests/test_src.py | Updated expected hash in the code generation test to match the new output. |
| code_generator_raw_uproot/servicex/templates/transform_single_file.py | Added timing functions and refactored transformation logic for chunked processing along with enhanced error messaging. |
| code_generator_raw_uproot/servicex/raw_uproot_code_generator/request_translator.py | Changed query processing to yield results incrementally and improved variable naming for clarity. |
Comments suppressed due to low confidence (1)
code_generator_raw_uproot/servicex/raw_uproot_code_generator/request_translator.py:143
- [nitpick] Consider renaming 'arrfound' to a more descriptive name such as 'chunk_found' or 'has_found_chunk' for improved code readability.
arrfound = False
code_generator_raw_uproot/servicex/templates/transform_single_file.py
Outdated
Show resolved
Hide resolved
|
I should note this is vaguely urgent, Marc has seen workflows that fail without this. |
BenGalewsky
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sufficiently large uproot-raw requests could allocate amounts of memory too large to fit in the default 1 GB Kubernetes limit (as they built the final results in-memory). We now instead write out the results of each
uproot.iteratechunk as they arrive. Take the opportunity to refactor a few aspects of the writing code.Fixes #1045