Skip to content

Commit c0f717c

Browse files
committed
fix breaking tests
1 parent 456c581 commit c0f717c

File tree

1 file changed

+20
-19
lines changed

1 file changed

+20
-19
lines changed

transformer_sidecar/tests/test_servicex_adapter.py

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,9 @@ class TestServiceXAdapter:
3434

3535
def test_init(self, mocker):
3636
import requests
37+
3738
mock_session = mocker.MagicMock(requests.session)
38-
mocker.patch('requests.session', return_value=mock_session)
39+
mocker.patch("requests.session", return_value=mock_session)
3940
mock_session.mount = mocker.Mock()
4041
ServiceXAdapter("http://foo.com")
4142
retries = mock_session.mount.mock_calls[0][1][1].max_retries
@@ -44,49 +45,49 @@ def test_init(self, mocker):
4445

4546
def test_put_file_complete(self, mocker, caplog):
4647
import requests
48+
4749
caplog.set_level(logging.INFO)
4850
mock_session = mocker.MagicMock(requests.session)
4951
mock_session.mount = mocker.Mock()
5052
mock_session.put = mocker.Mock()
51-
mocker.patch('requests.session', return_value=mock_session)
53+
mocker.patch("requests.session", return_value=mock_session)
5254

5355
adapter = ServiceXAdapter("http://foo.com")
54-
rec = FileCompleteRecord("42", "my-root.root",
55-
42, "testing",
56-
1, 2, 3)
56+
rec = FileCompleteRecord("42", "my-root.root", 42, "testing", 1, 2, 3, "file://s3-object-name")
5757

5858
adapter.put_file_complete(rec)
5959
mock_session.put.assert_called()
6060
args = mock_session.put.call_args
61-
assert args[0][0] == 'http://foo.com/file-complete'
62-
doc = args[1]['json']
63-
assert doc['status'] == 'testing'
64-
assert doc['total-time'] == 1
65-
assert doc['total-events'] == 2
66-
assert doc['file-path'] == 'my-root.root'
67-
assert doc['file-id'] == 42
68-
assert doc['avg-rate'] == 2
61+
assert args[0][0] == "http://foo.com/file-complete"
62+
doc = args[1]["json"]
63+
assert doc["status"] == "testing"
64+
assert doc["total-time"] == 1
65+
assert doc["total-events"] == 2
66+
assert doc["file-path"] == "my-root.root"
67+
assert doc["file-id"] == 42
68+
assert doc["avg-rate"] == 2
6969

7070
assert len(caplog.records) == 1
7171
assert caplog.records[0].levelno == logging.INFO
7272
assert caplog.records[0].msg == "Put file complete."
7373

7474
def test_put_file_complete_retry(self, mocker, caplog):
7575
import requests
76+
7677
caplog.set_level(logging.INFO)
7778
mock_session = mocker.MagicMock(requests.session)
7879
mock_session.mount = mocker.Mock()
79-
mock_session.put = mocker.Mock(side_effect=[requests.exceptions.ConnectionError, 200])
80-
mocker.patch('requests.session', return_value=mock_session)
80+
mock_session.put = mocker.Mock(
81+
side_effect=[requests.exceptions.ConnectionError, 200]
82+
)
83+
mocker.patch("requests.session", return_value=mock_session)
8184

8285
adapter = ServiceXAdapter("http://foo.com")
83-
rec = FileCompleteRecord("42", "my-root.root",
84-
42, "testing",
85-
1, 2, 3)
86+
rec = FileCompleteRecord("42", "my-root.root", 42, "testing", 1, 2, 3, "file://s3-object-name")
8687
adapter.put_file_complete(rec)
8788
assert mock_session.put.call_count == 2
8889
assert len(caplog.records) == 2
8990
assert caplog.records[0].levelno == logging.WARNING
90-
assert caplog.records[0].msg == '%s, retrying in %s seconds...'
91+
assert caplog.records[0].msg == "%s, retrying in %s seconds..."
9192
assert caplog.records[1].levelno == logging.INFO
9293
assert caplog.records[1].msg == "Put file complete."

0 commit comments

Comments
 (0)