Change a bit of wording and add dots at the end of each exception

Author: sroze

src/Symfony/Bundle/FrameworkBundle/Command/MessageConsumeCommand.php

@@ -38,12 +38,11 @@ protected function configure()
                 new InputArgument('receiver', InputArgument::REQUIRED, 'Name of the receiver'),
                 new InputOption('bus', 'b', InputOption::VALUE_REQUIRED, 'Name of the bus to dispatch the messages to', 'message_bus'),
             ))
-            ->setDescription('Consume a message')
+            ->setDescription('Consumes a message')
             ->setHelp(<<<'EOF'
-The <info>%command.name%</info> command consume a message and dispatch it to the message bus.
-
-    %command.full_name% <consumer-service-name>
+The <info>%command.name%</info> command consumes a message and dispatches it to the message bus.
 
+    <info>php %command.full_name% <consumer-service-name></info>
 EOF
             )
         ;
@@ -58,15 +57,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $container = $this->getApplication()->getKernel()->getContainer();
 
         if (!$container->has($receiverName = $input->getArgument('receiver'))) {
-            throw new \RuntimeException(sprintf('Receiver "%s" does not exist', $receiverName));
+            throw new \RuntimeException(sprintf('Receiver "%s" does not exist.', $receiverName));
         } elseif (!($receiver = $container->get($receiverName)) instanceof ReceiverInterface) {
-            throw new \RuntimeException(sprintf('Receiver "%s" is not a valid message consumer. It must implement the interface "%s"', $receiverName, ReceiverInterface::class));
+            throw new \RuntimeException(sprintf('Receiver "%s" is not a valid message consumer. It must implement the "%s" interface.', $receiverName, ReceiverInterface::class));
         }
 
         if (!$container->has($busName = $input->getOption('bus'))) {
-            throw new \RuntimeException(sprintf('Bus "%s" does not exist', $busName));
+            throw new \RuntimeException(sprintf('Bus "%s" does not exist.', $busName));
         } elseif (!($messageBus = $container->get($busName)) instanceof MessageBusInterface) {
-            throw new \RuntimeException(sprintf('Bus "%s" is not a valid message bus. It must implement the interface "%s"', $busName, MessageBusInterface::class));
+            throw new \RuntimeException(sprintf('Bus "%s" is not a valid message bus. It must implement the "%s" interface.', $busName, MessageBusInterface::class));
         }
 
         $worker = new Worker($receiver, $messageBus);

src/Symfony/Component/Message/Asynchronous/Transport/ReceivedMessage.php

@@ -11,11 +11,13 @@
 
 namespace Symfony\Component\Message\Asynchronous\Transport;
 
+use Symfony\Component\Message\Asynchronous\Middleware\SendMessageMiddleware;
+
 /**
  * Wraps a received message. This is mainly used by the `SendMessageMiddleware` middleware to identify
  * a message should not be sent if it was just received.
  *
- * @see \Symfony\Component\Message\Asynchronous\Middleware\SendMessageMiddleware
+ * @see SendMessageMiddleware
  *
  * @author Samuel Roze <samuel.roze@gmail.com>
  */

src/Symfony/Component/Message/ContainerHandlerLocator.php

@@ -20,9 +20,6 @@
  */
 class ContainerHandlerLocator implements HandlerLocatorInterface
 {
-    /**
-     * @var ContainerInterface
-     */
     private $container;
 
     public function __construct(ContainerInterface $container)
@@ -35,7 +32,7 @@ public function resolve($message): callable
         $messageKey = get_class($message);
 
         if (!$this->container->has($messageKey)) {
-            throw new NoHandlerForMessageException(sprintf('No handler for message "%s"', $messageKey));
+            throw new NoHandlerForMessageException(sprintf('No handler for message "%s".', $messageKey));
         }
 
         return $this->container->get($messageKey);

src/Symfony/Component/Message/DependencyInjection/MessagePass.php

@@ -59,7 +59,7 @@ private function registerHandlers(ContainerBuilder $container)
                 $handles = isset($tag['handles']) ? $tag['handles'] : $this->guessHandledClass($container, $serviceId);
 
                 if (!class_exists($handles)) {
-                    throw new RuntimeException(sprintf('The message class "%s" declared in `__invoke` function of service "%s" does not exist', $handles, $serviceId));
+                    throw new RuntimeException(sprintf('The message class "%s" declared in `__invoke` function of service "%s" does not exist.', $handles, $serviceId));
                 }
 
                 $priority = isset($tag['priority']) ? $tag['priority'] : 0;
@@ -96,17 +96,17 @@ private function guessHandledClass(ContainerBuilder $container, string $serviceI
         try {
             $method = $reflection->getMethod('__invoke');
         } catch (\ReflectionException $e) {
-            throw new RuntimeException(sprintf('Service "%s" should have an `__invoke` function', $serviceId));
+            throw new RuntimeException(sprintf('Service "%s" should have an `__invoke` function.', $serviceId));
         }
 
         $parameters = $method->getParameters();
         if (1 !== count($parameters)) {
-            throw new RuntimeException(sprintf('`__invoke` function of service "%s" must have exactly one parameter', $serviceId));
+            throw new RuntimeException(sprintf('`__invoke` function of service "%s" must have exactly one parameter.', $serviceId));
         }
 
         $parameter = $parameters[0];
         if (null === $parameter->getClass()) {
-            throw new RuntimeException(sprintf('The parameter of `__invoke` function of service "%s" must type hint the Message class it handles', $serviceId));
+            throw new RuntimeException(sprintf('The parameter of `__invoke` function of service "%s" must type hint the Message class it handles.', $serviceId));
         }
 
         return $parameter->getClass()->getName();

src/Symfony/Component/Message/Handler/ChainHandler.php

@@ -29,7 +29,7 @@ class ChainHandler
     public function __construct(array $handlers)
     {
         if (empty($handlers)) {
-            throw new \InvalidArgumentException('A collection of message handlers requires at least one handler');
+            throw new \InvalidArgumentException('A collection of message handlers requires at least one handler.');
         }
 
         $this->handlers = $handlers;

src/Symfony/Component/Message/HandlerLocator.php

@@ -36,7 +36,7 @@ public function resolve($message): callable
         $messageKey = get_class($message);
 
         if (!isset($this->messageToHandlerMapping[$messageKey])) {
-            throw new NoHandlerForMessageException(sprintf('No handler for message "%s"', $messageKey));
+            throw new NoHandlerForMessageException(sprintf('No handler for message "%s".', $messageKey));
         }
 
         $handler = $this->messageToHandlerMapping[$messageKey];

src/Symfony/Component/Message/README.md

@@ -162,7 +162,7 @@ class ImportantActionToEmailSender implements SenderInterface
     public function send($message)
     {
         if (!$message instanceof ImportantAction) {
-            throw new \InvalidArgumentException(sprintf('Producer only supports "%s" messages', ImportantAction::class));
+            throw new \InvalidArgumentException(sprintf('Producer only supports "%s" messages.', ImportantAction::class));
         }
         
         $this->mailer->send(

src/Symfony/Component/Message/Transport/Serialization/DecoderInterface.php

@@ -17,7 +17,9 @@
 interface DecoderInterface
 {
     /**
-     * Decode the message from an encoded-form. The `$encodedMessage` parameter is a key-value array that
+     * Decodes the message from an encoded-form.
+     *
+     * The `$encodedMessage` parameter is a key-value array that
      * describes the message, that will be used by the different adapters.
      *
      * The most common keys are:

src/Symfony/Component/Message/Transport/Serialization/EncoderInterface.php

@@ -17,7 +17,7 @@
 interface EncoderInterface
 {
     /**
-     * Encode a message to a common format understandable by adapters. The encoded array should only
+     * Encodes a message to a common format understandable by adapters. The encoded array should only
      * contain scalar and arrays.
      *
      * The most common keys of the encoded array are:

src/Symfony/Component/Message/Transport/Serialization/SymfonySerialization.php

@@ -40,9 +40,9 @@ public function __construct(SerializerInterface $serializer, string $format = 'j
     public function decode(array $encodedMessage)
     {
         if (empty($encodedMessage['body']) || empty($encodedMessage['headers'])) {
-            throw new \InvalidArgumentException('Encoded message should have at least a `body` some `headers`');
+            throw new \InvalidArgumentException('Encoded message should have at least a `body` some `headers`.');
         } elseif (empty($encodedMessage['headers']['type'])) {
-            throw new \InvalidArgumentException('Encoded message does not have a `type` header');
+            throw new \InvalidArgumentException('Encoded message does not have a `type` header.');
         }
 
         return $this->serializer->deserialize($encodedMessage['body'], $encodedMessage['headers']['type'], $this->format);