Skip to content

Commit 0e86784

Browse files
committed
Fix multiple typos from Javier's review
1 parent 6505049 commit 0e86784

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

src/Symfony/Bundle/FrameworkBundle/Command/MessageConsumeCommand.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
5858
$container = $this->getApplication()->getKernel()->getContainer();
5959

6060
if (!$container->has($receiverName = $input->getArgument('receiver'))) {
61-
throw new \RuntimeException(sprintf('Receiver "%s" do not exists', $receiverName));
61+
throw new \RuntimeException(sprintf('Receiver "%s" does not exist', $receiverName));
6262
} elseif (!($receiver = $container->get($receiverName)) instanceof ReceiverInterface) {
63-
throw new \RuntimeException(sprintf('Receiver "%s" is not a valid message consumer. It should implement the interface "%s"', $receiverName, ReceiverInterface::class));
63+
throw new \RuntimeException(sprintf('Receiver "%s" is not a valid message consumer. It must implement the interface "%s"', $receiverName, ReceiverInterface::class));
6464
}
6565

6666
if (!$container->has($busName = $input->getOption('bus'))) {
67-
throw new \RuntimeException(sprintf('Bus "%s" do not exists', $busName));
67+
throw new \RuntimeException(sprintf('Bus "%s" does not exist', $busName));
6868
} elseif (!($messageBus = $container->get($busName)) instanceof MessageBusInterface) {
69-
throw new \RuntimeException(sprintf('Bus "%s" is not a valid message bus. It should implement the interface "%s"', $busName, MessageBusInterface::class));
69+
throw new \RuntimeException(sprintf('Bus "%s" is not a valid message bus. It must implement the interface "%s"', $busName, MessageBusInterface::class));
7070
}
7171

7272
foreach ($receiver->receive() as $message) {

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/messages.html.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
<span class="icon">{{ include('@WebProfiler/Icon/messages.svg') }}</span>
88
<strong>Messages</strong>
99

10-
{% if collector.messages | length > 0 %}
10+
{% if collector.messages|length > 0 %}
1111
<span class="count">
12-
<span>{{ collector.messages | length }}</span>
12+
<span>{{ collector.messages|length }}</span>
1313
</span>
1414
{% endif %}
1515
</span>

src/Symfony/Component/Message/ContainerHandlerLocator.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,27 +16,28 @@
1616

1717
/**
1818
* @author Miha Vrhovnik <miha.vrhovnik@gmail.com>
19+
* @author Samuel Roze <samuel.roze@gmail.com>
1920
*/
2021
class ContainerHandlerLocator implements HandlerLocatorInterface
2122
{
2223
/**
2324
* @var ContainerInterface
2425
*/
25-
private $serviceLocator;
26+
private $container;
2627

27-
public function __construct(ContainerInterface $serviceLocator)
28+
public function __construct(ContainerInterface $container)
2829
{
29-
$this->serviceLocator = $serviceLocator;
30+
$this->container = $container;
3031
}
3132

3233
public function resolve($message): callable
3334
{
3435
$messageKey = get_class($message);
3536

36-
if (!$this->serviceLocator->has($messageKey)) {
37+
if (!$this->container->has($messageKey)) {
3738
throw new NoHandlerForMessageException(sprintf('No handler for message "%s"', $messageKey));
3839
}
3940

40-
return $this->serviceLocator->get($messageKey);
41+
return $this->container->get($messageKey);
4142
}
4243
}

src/Symfony/Component/Message/Transport/Serialization/SymfonySerialization.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function decode(array $encodedMessage)
4242
if (empty($encodedMessage['body']) || empty($encodedMessage['headers'])) {
4343
throw new \InvalidArgumentException('Encoded message should have at least a `body` some `headers`');
4444
} elseif (empty($encodedMessage['headers']['type'])) {
45-
throw new \InvalidArgumentException('Encoded message do not have a `type` header');
45+
throw new \InvalidArgumentException('Encoded message does not have a `type` header');
4646
}
4747

4848
return $this->serializer->deserialize($encodedMessage['body'], $encodedMessage['headers']['type'], $this->format);

0 commit comments

Comments
 (0)