just commit

Author: Petr Sramek

src/DropoutCoder.PolylineAlgorithm/ICoordinateValidator.cs

@@ -66,6 +66,16 @@ internal static class Coordinate
             /// </summary>
             public const int MaxLongitude = 180;
 
+            /// <summary>
+            /// Defines the maximum value for latitude
+            /// </summary>
+            public const int MinLatitude = -MaxLatitude;
+
+            /// <summary>
+            /// Defines the maximum value for longitude
+            /// </summary>
+            public const int MinLongitude = -MaxLongitude;
+
             #endregion
         }
     }

src/DropoutCoder.PolylineAlgorithm/Internal/Constants.cs

@@ -19,7 +19,19 @@ internal class CoordinateValidator
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public bool IsValid((double Latitude, double Longitude) coordinate)
         {
-            return Math.Abs(coordinate.Latitude) <= Constants.Coordinate.MaxLatitude && Math.Abs(coordinate.Longitude) <= Constants.Coordinate.MaxLongitude;
+            return IsValidLatitude(coordinate.Latitude) && IsValidLongitude(coordinate.Longitude);
+        }
+
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        public bool IsValidLatitude(double latitude)
+        {
+            return latitude >= Constants.Coordinate.MinLatitude && latitude <= Constants.Coordinate.MaxLatitude;
+        }
+
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        public bool IsValidLongitude(double longitude)
+        {
+            return longitude >= Constants.Coordinate.MinLongitude && longitude <= Constants.Coordinate.MaxLongitude;
         }
 
         #endregion

src/DropoutCoder.PolylineAlgorithm/Internal/CoordinateValidator.cs

@@ -0,0 +1,6 @@
+namespace DropoutCoder.PolylineAlgorithm
+{
+    public static class PolylineAlgorithm
+    {
+    }
+}

src/DropoutCoder.PolylineAlgorithm/PolylineAlgorithm.cs

@@ -6,7 +6,6 @@
 namespace DropoutCoder.PolylineAlgorithm
 {
     using DropoutCoder.PolylineAlgorithm.Internal;
-    using Microsoft.Extensions.ObjectPool;
     using System;
     using System.Collections.Generic;
     using System.Linq;
@@ -16,7 +15,6 @@ namespace DropoutCoder.PolylineAlgorithm
     public sealed class PolylineEncoder : IPolylineEncoder
     {
         private readonly CoordinateValidator _validator = new CoordinateValidator();
-        private readonly ObjectPool<StringBuilder> _pool = new DefaultObjectPoolProvider().CreateStringBuilderPool(5, 250);
 
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public IEnumerable<(double Latitude, double Longitude)> Decode(char[] polyline)
@@ -49,6 +47,7 @@ public sealed class PolylineEncoder : IPolylineEncoder
 
                 var coordinate = (GetCoordinate(latitude), GetCoordinate(longitude));
 
+                // Validating decoded coordinate. If not valid exception is thrown
                 if (!_validator.IsValid(coordinate))
                 {
                     throw new InvalidOperationException(ExceptionMessageResource.PolylineCharArrayIsMalformed);
@@ -106,7 +105,7 @@ public string Encode(IEnumerable<(double Latitude, double Longitude)> coordinate
             // Initializing local variables
             int previousLatitude = 0;
             int previousLongitude = 0;
-            var sb = _pool.Get();
+            var sb = new StringBuilder(coordinates.Count() * 5);
 
             // Looping over coordinates and building encoded result
             foreach (var coordinate in coordinates)
@@ -121,13 +120,10 @@ public string Encode(IEnumerable<(double Latitude, double Longitude)> coordinate
                 previousLongitude = longitude;
             }
 
-            var result = sb.ToString();
-
-            _pool.Return(sb);
-
-            return result;
+            return sb.ToString();
 
             #region Local functions
+
             bool TryValidate(IEnumerable<(double Latitude, double Longitude)> collection, out ICollection<CoordinateValidationException> exceptions)
             {
                 exceptions = new List<CoordinateValidationException>(collection.Count());
@@ -165,7 +161,8 @@ IEnumerable<char> GetSequence(int value)
 
                 yield return (char)(rem + Constants.ASCII.QuestionMark);
             }
+
+            #endregion
         }
-        #endregion
     }
 }