Skip to content

Commit 83702af

Browse files
author
Petr Sramek
committed
fixes, cleanup
1 parent 7341c74 commit 83702af

File tree

8 files changed

+12
-20
lines changed

8 files changed

+12
-20
lines changed

benchmarks/PolylineAlgorithm.Benchmarks/PolylineAlgorithm.Benchmarks.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414
<IsPackable>false</IsPackable>
1515
</PropertyGroup>
1616

17-
<PropertyGroup>
18-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
19-
</PropertyGroup>
20-
2117
<ItemGroup>
2218
<PackageReference Include="BenchmarkDotNet" Version="0.*" />
2319
</ItemGroup>

benchmarks/PolylineAlgorithm.Benchmarks/PolylineDecoderBenchmark.cs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66
namespace PolylineAlgorithm.Benchmarks {
77
using BenchmarkDotNet.Attributes;
88
using BenchmarkDotNet.Engines;
9+
using BenchmarkDotNet.Order;
910
using PolylineAlgorithm.Internal;
1011

1112
[MemoryDiagnoser]
1213
[MarkdownExporter]
14+
[Orderer(SummaryOrderPolicy.FastestToSlowest)]
1315
public class PolylineDecoderBenchmark {
14-
private Consumer _consumer = new();
16+
private readonly Consumer _consumer = new();
1517

1618
public PolylineDecoder Decoder { get; set; }
1719

@@ -28,7 +30,8 @@ public void Setup() {
2830

2931
[Benchmark]
3032
[ArgumentsSource(nameof(GetPolylines))]
31-
public IEnumerable<(double, double)> Decode(string polyline) => Decoder
32-
.Decode(polyline);
33+
public void Decode(string polyline) => Decoder
34+
.Decode(polyline)
35+
.Consume(_consumer);
3336
}
3437
}

benchmarks/PolylineAlgorithm.Benchmarks/PolylineEncoderBenchmark.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66
namespace PolylineAlgorithm.Benchmarks {
77
using BenchmarkDotNet.Attributes;
88
using BenchmarkDotNet.Engines;
9+
using BenchmarkDotNet.Order;
910
using PolylineAlgorithm.Internal;
1011

1112
[MemoryDiagnoser]
1213
[MarkdownExporter]
14+
[Orderer(SummaryOrderPolicy.FastestToSlowest)]
1315
public class PolylineEncoderBenchmark {
14-
private Consumer _consumer = new();
16+
private readonly Consumer _consumer = new();
1517

1618
public PolylineEncoder Encoder { get; set; }
1719

benchmarks/PolylineAlgorithm.Benchmarks/Program.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ internal class Program {
1010
static void Main(string[] _) {
1111
BenchmarkRunner
1212
.Run<PolylineEncoderBenchmark>();
13+
BenchmarkRunner
14+
.Run<PolylineDecoderBenchmark>();
1315
}
1416
}
1517
}

benchmarks/PolylineAlgorithm.Implementation.Benchmarks/PolylineAlgorithm.Implementation.Benchmarks.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@
1313
<PropertyGroup>
1414
<IsPackable>false</IsPackable>
1515
</PropertyGroup>
16-
17-
<PropertyGroup>
18-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
19-
</PropertyGroup>
2016

2117
<ItemGroup>
2218
<PackageReference Include="BenchmarkDotNet" Version="0.*" />

benchmarks/PolylineAlgorithm.Implementation.Benchmarks/PolylineEncoderBenchmark.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
namespace PolylineAlgorithm.Implementation.Benchmarks {
22
using BenchmarkDotNet.Attributes;
3-
using BenchmarkDotNet.Engines;
43
using Microsoft.Extensions.ObjectPool;
54
using System.Collections.Generic;
65
using System.Text;

src/PolylineAlgorithm.DependencyInjection/PolylineAlgorithm.DependencyInjection.csproj

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,10 @@
1414
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
1515
<EnableNETAnalyzers>true</EnableNETAnalyzers>
1616
<IncludeOpenAPIAnalyzers>true</IncludeOpenAPIAnalyzers>
17-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
1817
</PropertyGroup>
1918

2019
<ItemGroup>
21-
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.*" />
20+
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="1.*" />
2221
</ItemGroup>
2322

2423
<ItemGroup>

src/PolylineAlgorithm/PolylineAlgorithm.csproj

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,7 @@
1515
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
1616
<EnableNETAnalyzers>true</EnableNETAnalyzers>
1717
<IncludeOpenAPIAnalyzers>true</IncludeOpenAPIAnalyzers>
18-
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
1918
</PropertyGroup>
20-
21-
<ItemGroup>
22-
<PackageReference Include="Microsoft.Extensions.ObjectPool" Version="9.*" />
23-
</ItemGroup>
2419

2520
<ItemGroup>
2621
<Compile Update="ExceptionMessageResource.Designer.cs">

0 commit comments

Comments
 (0)