Skip to content

Commit 3bb8b75

Browse files
author
Daniele Briggi
committed
fix(workflow): test to complete and lost disutils package
1 parent 0290ada commit 3bb8b75

File tree

2 files changed

+9
-34
lines changed

2 files changed

+9
-34
lines changed

.github/workflows/test.yml

Lines changed: 7 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
- name: Upload Code Coverage
4040
uses: codecov/codecov-action@v4
4141
env:
42-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
42+
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
4343

4444
examples-test:
4545
needs: code-test
@@ -129,17 +129,7 @@ jobs:
129129
working-directory: examples/with-plain-javascript
130130
run: |
131131
npm i
132-
echo "Dependencies installed"
133-
app_log=$(mktemp)
134-
npm start > "$app_log" 2>&1 &
135-
136-
app_pid=$!
137-
echo "App started"
138-
sleep 3
139-
kill "$app_pid" 2>/dev/null
140-
141-
node_test=$(<"$app_log")
142-
rm "$app_log"
132+
node_test=$(npm start)
143133
144134
if [[ "$node_test" == *"Composer: 'Angus Young, Malcolm Young, Brian Johnson',"* ]]; then
145135
echo "✅ node with-plain-javascript test passed"
@@ -154,15 +144,8 @@ jobs:
154144
if [ "$RUNNER_OS" != "Windows" ]; then
155145
bun i #re-installing dependencies in windows with bash causes a panic
156146
fi
157-
app_log=$(mktemp)
158-
bun start > "$app_log" 2>&1 &
159-
160-
app_pid=$!
161-
sleep 3
162-
kill "$app_pid" 2>/dev/null
163-
164-
bun_test=$(<"$app_log")
165-
rm "$app_log"
147+
148+
bun_test=$(bun start)
166149
167150
if [[ "$bun_test" == *"Composer: 'Angus Young, Malcolm Young, Brian Johnson',"* ]]; then
168151
echo "✅ bun with-plain-javascript test passed"
@@ -174,15 +157,7 @@ jobs:
174157
- name: deno with-plain-javascript
175158
working-directory: examples/with-plain-javascript
176159
run: |
177-
app_log=$(mktemp)
178-
deno run start > "$app_log" 2>&1 &
179-
180-
app_pid=$!
181-
sleep 3
182-
kill "$app_pid" 2>/dev/null
183-
184-
deno_test=$(<"$app_log")
185-
rm "$app_log"
160+
deno_test=$(deno run start)
186161
187162
if [[ "$deno_test" == *"Composer: 'Angus Young, Malcolm Young, Brian Johnson',"* ]]; then
188163
echo "✅ deno with-plain-javascript test passed"
@@ -491,8 +466,8 @@ jobs:
491466
xcode-version: 14.3
492467

493468
- name: build driver
494-
# distutils is required for the driver build and it was removed since python 3.13
495-
run: python3 -m pip install setuptools && npm i && npm run build && echo "DRIVER=$(npm pack --json | jq '.[0].filename')" >> $GITHUB_ENV
469+
# distutils is required for the driver build (dep. `node-gyp`) and it was removed since python 3.13
470+
run: brew install python-setuptools && npm i && npm run build && echo "DRIVER=$(npm pack --json | jq '.[0].filename')" >> $GITHUB_ENV
496471

497472
- name: install driver
498473
working-directory: examples/with-javascript-expo

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)