Defer Sorting AuthorizationAdvisors in addAdvisor

jzheaux · jzheaux · commit 1118b0ec63b8 · 2024-08-20T17:23:10.000-06:00
Issue gh-15658
diff --git a/core/src/main/java/org/springframework/security/authorization/method/AuthorizationAdvisorProxyFactory.java b/core/src/main/java/org/springframework/security/authorization/method/AuthorizationAdvisorProxyFactory.java
@@ -214,7 +214,6 @@ public void setAdvisors(Collection<AuthorizationAdvisor> advisors) {
 	 */
 	public void addAdvisor(AuthorizationAdvisor advisor) {
 		this.advisors.add(advisor);
-		AnnotationAwareOrderComparator.sort(this.advisors);
 	}
 
 	/**

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,6 @@ public void setAdvisors(Collection<AuthorizationAdvisor> advisors) {`
`214`	`214`	`*/`
`215`	`215`	`public void addAdvisor(AuthorizationAdvisor advisor) {`
`216`	`216`	`this.advisors.add(advisor);`
`217`		`- AnnotationAwareOrderComparator.sort(this.advisors);`
`218`	`217`	`}`
`219`	`218`
`220`	`219`	`/**`