GH-965 - Asciidoctor.toInlineCode(String) now renders local method references correctly.

Previously, the missing type caused the module lookup to fail with an exception.

Author: odrotbohm

spring-modulith-docs/src/main/java/org/springframework/modulith/docs/Asciidoctor.java

@@ -105,10 +105,14 @@ public String toInlineCode(String source) {
 		var type = parts[0];
 		var methodSignature = parts.length == 2 ? Optional.of(parts[1]) : Optional.<String> empty();
 
+		if (type.isBlank()) {
+			return methodSignature.map(Asciidoctor::toCode).orElse(source);
+		}
+
 		return modules.getModuleByType(type)
 				.flatMap(it -> it.getType(type))
 				.map(it -> toOptionalLink(it, methodSignature))
-				.orElseGet(() -> String.format("`%s`", type));
+				.orElseGet(() -> toCode(type));
 	}
 
 	public String toInlineCode(JavaClass type) {
@@ -270,7 +274,7 @@ private String toBulletPoints(Stream<String> types) {
 	}
 
 	public String toBulletPoint(String source) {
-		return String.format("* %s", source);
+		return "* ".concat(source);
 	}
 
 	private String toOptionalLink(JavaClass source) {
@@ -355,7 +359,7 @@ private static String toLink(String source, String href) {
 	}
 
 	private static String toCode(String source) {
-		return String.format("`%s`", source);
+		return wrap(source, "`");
 	}
 
 	public static String startTable(String tableSpec) {
@@ -441,4 +445,8 @@ private static Optional<DocumentationSource> getSpringModulithDocsSource() {
 					return it;
 				});
 	}
+
+	private static final String wrap(String source, String chars) {
+		return chars + source + chars;
+	}
 }

spring-modulith-docs/src/test/java/org/springframework/modulith/docs/AsciidoctorUnitTests.java

@@ -29,7 +29,8 @@
  */
 class AsciidoctorUnitTests {
 
-	Asciidoctor asciidoctor = Asciidoctor.withJavadocBase(ApplicationModules.of("org.springframework.modulith"), "{javadoc}");
+	Asciidoctor asciidoctor = Asciidoctor.withJavadocBase(ApplicationModules.of("org.springframework.modulith"),
+			"{javadoc}");
 
 	@Test
 	void formatsInlineCode() {
@@ -64,8 +65,14 @@ void cleansUpJavadocForConfigurationProperties() {
 
 		ConfigurationProperties metadata = new ConfigurationProperties();
 
-		assertThat(metadata).containsExactly(new ConfigurationProperties.ConfigurationProperty("org.springframework.modulith.sample.test",
-				"Some test property of type {@link java.lang.Boolean}.", "java.lang.Boolean",
-				"com.acme.myproject.stereotypes.Stereotypes$SomeConfigurationProperties", "false"));
+		assertThat(metadata)
+				.containsExactly(new ConfigurationProperties.ConfigurationProperty("org.springframework.modulith.sample.test",
+						"Some test property of type {@link java.lang.Boolean}.", "java.lang.Boolean",
+						"com.acme.myproject.stereotypes.Stereotypes$SomeConfigurationProperties", "false"));
+	}
+
+	@Test // GH-965
+	void rendersLocalMethodReferencesCorrectly() {
+		assertThat(asciidoctor.toInlineCode("#someMethod()")).isEqualTo("`someMethod()`");
 	}
 }